FlyingZC commented on PR #39917:
URL: https://github.com/apache/shardingsphere/pull/39917#issuecomment-5757024450
### Result
**Review Result: Mergeable**
The candidate adds the documented Oracle syntax at the dialect parser
owner, preserves existing named-column semantics, and introduces paired parser
cases without
changing public contracts.
### Evidence
- Oracle 19c SQL Reference confirms `DROP UNUSED COLUMNS [CHECKPOINT
[integer]]`.
- Oracle parser owner reactor completed successfully.
- InternalOracleParserIT passed 1967 tests with no failures or errors.
- Exact candidate Spotless and Checkstyle checks passed.
- XML resources are valid and each SQL case has one matching expected case.
### Coverage
- Standalone local candidate based on
`apache/master@7e2dae148026f83b0108b0b1c9ae085c41dae4de`.
- Reviewed commit: `d80a2c977e82946004f7e8af3fea85fa198d7033`.
- Reviewed one Oracle G4 file, one Oracle visitor, and two Parser IT
resource files.
- Target dialect: Oracle; no repository-defined branch dialect requires
synchronization.
- Full repository verification was explicitly waived.
- Code-correctness review only; GitHub CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
