FlyingZC commented on PR #39914:
URL: https://github.com/apache/shardingsphere/pull/39914#issuecomment-5758455668
### Result
**Review Result: Mergeable**
The latest HEAD resolves both previously identified edge cases. No new
code-correctness blockers were found.
### Evidence
- `OracleDMLStatementVisitor.java:773-778` preserves parameter markers,
variables, and comments after rebuilding the statement for an outer `ORDER BY`;
a focused
bind-marker test covers this behavior.
- `PLSQL.g4:581-594` restores `%TYPE` to the original `typeName` path and
limits three-part names to ordinary collection types.
- `OracleDDLStatementVisitor.java:2383-2389` correctly distinguishes a
direct `typeName` from the nested `typeName` in a collection type.
- Oracle Visitor tests `3/3`, Parser IT `1966/1966`, and Rewrite IT
`1019/1019` all passed.
### Coverage
- Reviewed head: `1c7d3605e5f673b69850dc1f21d513122418ddf6`
- Base: `master` at `1bcf1101ad8bef3059674a463b740bda562887ee`
- The GitHub and local triple-dot file lists match, covering nine files.
- Reviewed both behavior clusters—parenthesized `WITH` queries and
qualified PL/SQL collection types—including the latest four-file fix delta.
- Covered grammar, visitor behavior, parameter state, metadata extraction,
compatibility, tests, and parser memory risks.
- This was a Code Correctness Review; CI was not queried or evaluated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
