terrymanu commented on PR #39918: URL: https://github.com/apache/shardingsphere/pull/39918#issuecomment-5769997973
### Result **Review Result: Mergeable** The placeholder branch now uses `TypedSPILoader.containsService`; existing behavior is preserved. No issues requiring a broader change were found. ### Evidence - Removed only the duplicate private matching methods and unused import. - Tests cover existing and missing types and verify that the placeholder branch calls neither `checkService` nor the SPI’s `init` method. - All 24 focused tests passed. Spotless checked both changed files; Checkstyle reported no violations. ### Coverage This is a standalone local candidate based on `7e2dae14802`. The review covers only `WorkflowAlgorithmUtils.java` and `WorkflowAlgorithmUtilsTest.java` in `mcp/support`. The conclusion concerns code correctness; CI was not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
