terrymanu commented on PR #39919: URL: https://github.com/apache/shardingsphere/pull/39919#issuecomment-5770205138
### Result **Review Result: Mergeable** The refactor preserves the numeric intersection behavior: `removeIf` removes the same values as the previous iterator loop. This is a code-scope result; CI was not reviewed. ### Evidence - The changed path receives mutable `ArrayList` or `LinkedList` values, and the existing heterogeneous-number tests exercise the intersection. [Changed code](https://github.com/apache/shardingsphere/blob/ff02ab55effc10101a45624964cab93d23dedc50/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/route/engine/condition/engine/WhereClauseShardingConditionEngine.java#L185-L200) - The focused `WhereClauseShardingConditionEngineTest` passed: 15 tests, 0 failures. - Local Checkstyle and Spotless checks both passed and included the changed file. ### Coverage - **Candidate:** Public PR head `ff02ab55effc10101a45624964cab93d23dedc50`; base and merge-base `adb00290890a50168f75a2f3b68accd5483e8acd`. No local candidate delta. - **Scope:** GitHub’s authoritative file list and the local triple-dot diff match: one production Java file, `features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/route/engine/condition/engine/WhereClauseShardingConditionEngine.java`. - **Requirement and behavior:** The PR is a refactor with no stated new project commitment. Review covered the changed numeric-intersection path, its producers and consumers, tests, and regression and performance risk; the final pass found no unresolved issue. - **Style verification:** `./mvnw -pl features/sharding/core -Pcheck checkstyle:check -B` — exit 0; `./mvnw -pl features/sharding/core -Pcheck spotless:check -B` — exit 0. Both checks covered the sole PR-impact file at the effective head. - **CI:** Not reviewed; this is a Code Correctness Review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
