terrymanu commented on PR #39927: URL: https://github.com/apache/shardingsphere/pull/39927#issuecomment-5787345379
### Result **Review Result: Mergeable** The local change is complete. The checker now keeps its runtime match state in a boolean and returns `TableDataConsistencyCheckResult` directly. The existing control flow for progress positions, `finished`, `matched`, early exit, and exception handling is unchanged. ### Evidence - All 4 focused tests passed, covering a match, a content mismatch, and an extra record on either side. - Spotless and Checkstyle passed for both changed files. The new test file passed the RAT license check. - The final diff check passed. The YAML Swapper, persistence format, and public interfaces were not changed. ### Coverage This local code correctness review covers the two task files against `HEAD` (`7860a8e93ef`). CI was not reviewed. The remaining risk is that the full test suite and a live Pipeline integration test were not run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
