terrymanu commented on PR #39932: URL: https://github.com/apache/shardingsphere/pull/39932#issuecomment-5797452109
### Result **Review Result: Mergeable** The local code correctness review found no blocking issues. The parser now reads dotted service names and returns the service name without the `POOLED`, `SHARED`, or `DEDICATED` suffix in the requested Easy Connect cases. ### Evidence - The [official Oracle JDBC URL documentation](https://docs.oracle.com/en/database/oracle/oracle-database/21/jajdb/oracle/jdbc/OracleDriver.html) supports dotted service names and an optional server mode. - `OracleConnectionPropertiesParserTest`: 17 tests passed, with 0 failures and 0 errors. - The targeted Spotless check passed; Checkstyle reported 0 violations in the two target files. ### Coverage Standalone local candidate; baseline: `680d94f8d44a9c80fbc72e85eec268148ee6c9ea`. The review covered all task changes in `OracleConnectionPropertiesParser.java` and `OracleConnectionPropertiesParserTest.java`. This is a code correctness result; CI was not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
