makssent commented on issue #39772: URL: https://github.com/apache/shardingsphere/issues/39772#issuecomment-5870990811
> [@makssent](https://github.com/makssent) please review and provide your suggestions on the approach that is right to be taken here. I think both approaches are possible, and it depends on the scope you want to take here. If you want to keep the current ShardingSphere implementation and only fix the issue, you can introduce a limit for the in-memory buffer. In that case, however, this should be treated as a ShardingSphere-specific limitation, not as the Firebird 65535-byte protocol limit, because Firebird applies that limit to a single segment, not to the whole BLOB. If you want to improve the implementation itself and make ShardingSphere Proxy behave closer to Firebird, then the second approach makes more sense: process/write BLOB segments incrementally instead of buffering the whole BLOB in memory. So I think the choice mainly depends on whether you want to make a small fix within the current implementation or change the BLOB handling implementation itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
