terrymanu commented on PR #40047: URL: https://github.com/apache/shardingsphere/pull/40047#issuecomment-5978569459
### Result **Review Result: Mergeable** Fixed the props mock in SchemaChangedHandlerTest by supplying real temporary configuration properties with the default value false. Existing behavior assertions remain intact. ### Evidence - The focused module install succeeded: both tests passed, and the original statistics refresh NPE no longer appeared. - Spotless and Checkstyle passed, each verified to cover the single changed file. - Independent review confirmed that no defensive constructs were added or strengthened. ### Coverage Standalone local candidate, original baseline 1c859abd8b5d. The only change is in mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/database/metadata/SchemaChangedHandlerTest.java:47. Reviewed the default configuration contract and the call path from the handler to the statistics refresh engine, covering root cause, impact, and test execution. No new contracts or unresolved issues; the final review found no additional issues. This is a code-scope review only. CI was not reviewed, and the full-repository install was not rerun. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
