This is an automated email from the ASF dual-hosted git repository.
terrymanu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 1400f97db3d Require independent review of defensive code changes
(#40048)
1400f97db3d is described below
commit 1400f97db3db1d6e95ec0f1c8701e508349bfd78
Author: Liang Zhang <[email protected]>
AuthorDate: Sun Oct 4 18:08:49 2026 +0800
Require independent review of defensive code changes (#40048)
* Fix temporary properties mock in schema handler tests
* Require independent review of defensive code changes
---
.codex/context/change-completion.md | 1 +
1 file changed, 1 insertion(+)
diff --git a/.codex/context/change-completion.md
b/.codex/context/change-completion.md
index 5e40d56682c..d33ff516e48 100644
--- a/.codex/context/change-completion.md
+++ b/.codex/context/change-completion.md
@@ -25,6 +25,7 @@ For every authorized code-writing task, including a
restoration or rollback that
2. Apply every triggered coding-standard and simplification rule to the
effective task delta. Treat scripts, searches, formatters, compilation, tests,
benchmarks, and review tools as evidence rather than proof, and fix every safe
in-scope violation.
3. Run the applicable verification and non-regression checks. An invalidated,
unmatched, missing, or inconclusive required result keeps the task incomplete.
4. Invoke `$review-pr` in Formal Review Mode for the complete task-owned
candidate. Use Code Correctness Review for a standalone local candidate unless
the user requests another focus. For a PR-backed candidate, apply the
public-head, remote-evidence, and mandatory style-verification gates; for a
standalone candidate, review only the original task baseline and attributed
task-owned delta.
+ - Assign an independent reviewer within the current task to perform a
read-only audit of defensive code added, extended or strengthened by the task
under the existing defensive-code rules.
5. Hand off only when the latest complete Formal Review returns `Review
Result: Mergeable` and no later code-affecting write or new evidence
invalidates it. Include that complete passing Formal Review report unchanged in
the final handoff.
6. When Formal Review returns `Not Mergeable` with a safe in-scope Change
Request, fix every required finding, repeat the task-delta audit, rerun
invalidated checks, and rerun Formal Review. Continue this loop until it
returns `Review Result: Mergeable`.
7. A scope expansion, missing authority, unresolved architecture choice,
high-risk action, `Review Incomplete`, or `Needs Discussion` result keeps the
task incomplete. Yield to the user only for the exact decision, authority, or
unavailable evidence needed to continue; do not claim successful completion or
provide commit artifacts while the task remains incomplete.
