terrymanu commented on PR #40053: URL: https://github.com/apache/shardingsphere/pull/40053#issuecomment-5981130251
### Result **Review Result: Mergeable** The old test class was removed. The three concurrency scenarios now reside in UT classes matching their production interfaces’ packages and names. Production code remains unchanged. ### Evidence - New UTs: `DistSQLQueryExecutorTest`, `DistSQLUpdateExecutorTest`, and `DatabaseRuleDefinitionExecutorTest`. - Dedicated fixtures and three SPI test registrations were migrated. The old `concurrent` package and its references were removed. - All 90 core module tests passed. Spotless and Checkstyle covered exactly 10 Java files. Apache RAT passed. ### Coverage The local candidate is based on 16d7c3f38b00 and covers all 21 changed paths in this iteration. Test ownership, SPI loading, regression scenarios, and final consistency were reviewed. Existing isolation assertions, timeouts, and thread cleanup semantics were preserved; no defensive behavior was added. Unrelated workspace changes were excluded from this implementation and review. This verdict covers code only; CI was not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
