terrymanu commented on PR #40054: URL: https://github.com/apache/shardingsphere/pull/40054#issuecomment-5981297144
### Result **Review Result: Mergeable** The shared `UniqueTableNames` constraint is integrated into Encrypt and rejects duplicate table names before persistence conversion. No blocking issues were found. ### Evidence - The shared layer has no feature dependencies and supports different table configuration types through public `getName()` methods. Case sensitivity, duplicate-name ordering, and the Encrypt error contract are preserved. Independent review of defensive checks passed. - The latest build and all 64 tests passed. Spotless and Checkstyle covered all 5 task Java files, and the root RAT check passed. - Packaged artifacts contain both shared types. The obsolete types, Checker, SPI registration, and unused exception have been removed. Both Native registrations, the `getName()` method, and packaged metadata were verified. - Configuration validation measurements with 10, 100, and 1000 tables showed no performance regression beyond sample variation. ### Coverage Standalone local candidate, with original baseline `16d7c3f38b009076dd21b38f61445543c40e5279`. All 12 task paths were reviewed: infra/common 3, Encrypt API 2, core 4, bilingual documentation 2, and Native metadata 1. Unrelated DistSQL changes were excluded; Mask was not modified. All three review perspectives and final convergence are complete, with no new findings. All task files remain in their reviewed state. The result covers code readiness only; CI was not reviewed. Native image execution was not verified because the local tool does not support the repository’s unified metadata format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
