terrymanu commented on PR #40055: URL: https://github.com/apache/shardingsphere/pull/40055#issuecomment-5982072028
### Result **Review Result: Mergeable** Mask table-name uniqueness validation now uses shared Bean Validation and rejects duplicate configurations before persistence conversion. No blocking issues were found. ### Evidence - Preserves Default→Type validation order, empty configurations, and case sensitivity. Tests cover the error contract and aggregation of multiple Type violations. Removing the Checker does not remove validation from existing supported entry points. The independent defensive-code audit passed. - All 55 tests passed. Spotless and Checkstyle passed for exactly the two changed Java files. RAT is not applicable because no files were added and no license headers or RAT configuration were changed. - The annotation is included in the API artifact. The old Checker, test, and SPI registration are absent; EmptyChecker remains. Native getName() registration, complete JSON, and packaged metadata were verified. - Fully warmed, interleaved measurements of both validation paths with 10/100/1000 tables found no reproducible performance regression beyond observed sample variation. ### Coverage Standalone local candidate against baseline c87252791f88992aabe04ab0bfe76876629219cb. All six paths were reviewed: two Mask API files, three core files, and one Native metadata file. Shared code, POMs, DistSQL, exceptions, and documentation were unchanged. The file inventory, three discovery paths, and final convergence were completed. No new findings remained, and all candidate fingerprints stayed unchanged. This review covers the local code; CI was not reviewed. Native-image execution was not verified because the local toolchain does not support the repository's unified metadata format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
