The GitHub Actions job "Required - Check" on shardingsphere.git/fix-39935-firebird-common-responses has succeeded. Run started by GitHub user abhinav-phi (triggered by terrymanu).
Head commit for run: 8bd61551ecffa8e046c9776aeb9032b970ed721d / Abhinav <[email protected]> Correct slice response encoding and address review feedback The slice response wrote the slice length three times: once as the standalone length, once as a bare integer, and once as the length prefix of the slice data buffer. The wire protocol documentation marks this section as possibly not reflecting the actual encoding, and the third field was inferred from that note rather than verified. Firebird 5.0.3 src/remote/protocol.cpp case op_slice encodes p_slr_length and then delegates to xdr_slice, which is xdr_long followed by xdr_opaque of the data. That is two length fields, not three. The redundant writeInt4 is removed, so an empty slice is now 12 bytes instead of 16 and a 4-byte slice is followed by no trailing bytes. Also addresses the two remaining review findings: - Removes the two assertGetters cases, which only covered Lombok generated accessors rather than the serialization behaviour owned by the response packets. - Places the private helpers directly after their callers and puts the Stream.of expression on a single line, per the declaration order and 200-character wrapping rules in CODE_OF_CONDUCT.md. The slice and inline blob tests now assert against literal byte arrays derived by hand from the XDR layout, with the operation codes hardcoded, instead of deriving the expected bytes by re-invoking the production writer, which made the assertions self-confirming. Generated-by: MiniMax Code (MCode) Report URL: https://github.com/apache/shardingsphere/actions/runs/36905911485 With regards, GitHub Actions via GitBox
