terrymanu commented on PR #40058: URL: https://github.com/apache/shardingsphere/pull/40058#issuecomment-6007874802
### Result **Review Result: Mergeable** JDBC DistSQL was exercised using the existing Proxy test cases and datasets. All confirmed issues and verification gaps have been resolved. ### Evidence - All 1,257 valid verification runs passed: 650 for JDBC and 607 for Proxy, with no failures, errors, or skips. - The 25 Hive runs loaded the newly installed Core/Hive bytecode. The existing 1,232 runs covered unchanged execution paths; no claim was made that the old Proxy image contained the new Core. - All 16 new owner test runs and 6 consumer test runs passed. Branch coverage reached 100% for both Hive owners. The existing evidence from 45 tests remains valid. - Style checks, compilation, and RAT passed for the current 9 Java files. Hashes matched for all 16 files. Historical startup failures were retained, and the corresponding groups passed on rerun. ### Coverage Local candidate, based on `5a9f1312677cbd9c87d1c0da0d34324b5fdf1ba1`. All 42 authorized paths were accounted for: 16 retained changes and 26 reverted changes. All source code was reviewed, and the original Proxy contract was preserved. Parameters, complete assertions, pool lifecycle, native/wrapped connections, defensive code, and performance were checked. No new project-level API/SPI commitments were introduced. The three-lens review and final convergence are complete, with zero new candidates and no remaining gaps; ledger validation passed. This conclusion covers only the reviewed code scope; remote CI was not reviewed. Jev was not involved. Unattributed changes were compared and excluded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
