terrymanu commented on PR #40061: URL: https://github.com/apache/shardingsphere/pull/40061#issuecomment-6008657329
### Result **Review Result: Mergeable** The four workflow fixes are complete. This verdict covers local code readiness only; the actual parser tests failed. ### Evidence - Changed the target POM to test/it/parser/pom.xml, retained the enabling flag, and selected the corresponding test class for each matrix entry. - Removed continue-on-error and added !cancelled() to the upload step. Existing build steps, triggers, concurrency settings, and artifact names remain unchanged. - YAML, matrix mappings, and preserved settings passed verification. Spotless checked exactly one file and exited with code 0. - MySQL: 68,262 tests executed, errors=102, skipped=0. - PostgreSQL: 39,443 tests executed, errors=211, skipped=0. - Both Maven runs exited with code 1 during Failsafe verify. Both CSV reports were generated. The investigated NPEs already existed in the original Java baseline; exception handling was not broadened, and no result gates were added. ### Coverage Standalone local candidate against the original baseline a4106e8d4b4. Only the four changes in nightly-sql-parser.yml were made: 7 lines added and 3 removed, with no Java/POM changes. Root cause, impact, and runtime behavior were reviewed. The independent defensive-code audit found no issues; the final review found no additional findings. Checkstyle does not cover this workflow, and RAT was not required. The full repository build, GitHub CI, and actual artifact upload were not verified. Not every parser error was individually diagnosed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
