terrymanu commented on PR #40062: URL: https://github.com/apache/shardingsphere/pull/40062#issuecomment-6009073335
### Result **Review Result: Mergeable** The local candidate satisfies the authorized native workflow consolidation requirements. No blocking issues were found; this conclusion covers code readiness only. ### Evidence - The [GraalVM workflow](/Users/zhangliang/IdeaProjects/shardingsphere/.github/workflows/graalvm.yml:31) retains the original cron schedule. Scheduled runs preserve the nightly enablement condition and Maven options. PR/manual conditions, environment, and concurrency keys remain unchanged; scheduled runs use a separate concurrency group. - [Regular nightly CI](/Users/zhangliang/IdeaProjects/shardingsphere/.github/workflows/nightly-ci.yml:40) is fully preserved. Only the duplicate native job was removed. The native matrix, version, test commands, and 90-minute timeout remain unchanged. - YAML parsing and complete baseline comparisons passed, including 18 event/repository/enablement combinations. The environment-writing step executed successfully and reproduced the original nightly options exactly. Both files passed diff checks. The exact-file Spotless check exited with code 0, covering both YAML files with no formatting changes required and no cache skips. - Event separation, conditional expressions, and environment propagation follow GitHub’s official [multiple-event rules](https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#using-activity-types-and-filters-with-multiple-events), [expression rules](https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#operators), and [GITHUB_ENV rules](https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-commands#setting-an-environment-variable). ### Coverage Standalone local candidate: baseline `0a1ad58db7f4fa04712b28c9e1bbc65557375518` plus task-owned working-tree changes in two files, with no task-created Git commits. The review fully covered native event routing, enablement, environment, cancellation behavior, and preservation of regular CI. Unrelated user changes and concurrent native test changes were excluded. All three discovery passes were completed. The inventory and ledger covered 2/2 files, and the final convergence pass found no new issues or unresolved evidence gaps. Checkstyle does not apply to YAML; RAT was not triggered. Neither actionlint nor native tests were run, and remote CI was not reviewed. Actual execution on GitHub runners remains unverified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
