terrymanu commented on PR #40086: URL: https://github.com/apache/shardingsphere/pull/40086#issuecomment-6019668967
### Result **Review Result: Mergeable** Code Correctness Review passed. The change supplies the required mode for the target include entry, with no scope expansion or regression found. This verdict covers only the correctness of the local candidate. ### Evidence - The actual diff only adds `mode: Cluster` at `.github/workflows/nightly-e2e-sql.yml:82`. This matches the existing Cluster coverage for proxy + passthrough and is passed to Maven at line 133. - Under [GitHub matrix semantics](https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idstrategymatrixinclude), the target additional-options value conflicts with the base matrix axis and creates a separate combination. Full YAML parsing and local matrix expansion passed with exit code 0: both versions contain 180 combinations, the target mode becomes Cluster, and the other 179 combinations remain unchanged. The rendered command contains `-De2e.artifact.modes=Cluster`. - `test/e2e/env/src/test/java/org/apache/shardingsphere/test/e2e/env/runtime/type/ArtifactEnvironment.java:45` reads the modes. `E2ETestEnvironment.java:65–67` in the parent directory requires that collection to be nonempty. Supplying the missing upstream parameter directly fixes this invalid-environment path. The default driver version in root `pom.xml:131` is already 8.4.0, so this change restores the explicit job rather than introducing coverage for that version. ### Coverage Standalone local candidate. Original task baseline: `672b45b4d9126e8e9f25c1bdb955545c10961328`. Current HEAD: `4e474f637afec7a09f536b2439aae50699506aab`, plus the single uncommitted line above. The authoritative scope contains only the target workflow; unrelated commits and untracked files were excluded. Review covered root cause and behavior, impact and contracts, validation and runtime behavior, risk classification, and final convergence. No unresolved blocking facts remain. The change preserves existing coverage commitments and adds no supported behavior or production runtime cost. The independent defensive-code audit passed: mode is an explicit required input, and the change adds no fallback, redundant validation, or failure-suppression mechanism. Applicable written YAML standards were checked manually. The current candidate passed the exact-file Spotless check with exit code 0; the log confirms that one file was selected and was clean. Checkstyle is not applicable under the file-type scope in `src/resources/checkstyle.xml:22`. `git diff --check` passed with exit code 0. RAT was not triggered because no files, license headers, or RAT configuration were added or changed. CI was not reviewed. Actions schema lint and E2E were not run. YAML parsing and matrix simulation do not establish successful Actions or E2E execution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
