terrymanu commented on PR #40090: URL: https://github.com/apache/shardingsphere/pull/40090#issuecomment-6033013961
### Result **Review Result: Mergeable** No blocking issues were found within the reviewed code scope. The fix is necessary and stays within the minimal boundary. ### Evidence - `StandardDatabaseProxyConnector:393–421`: skips cancel only when the Statement is confirmed closed, while retaining close. If the state check throws SQLException, the original cleanup behavior continues. Cached PreparedStatement handling, exception chaining, and resource cleanup order remain unchanged. - `StandardDatabaseProxyConnectorTest:760, 771`: the closed-Statement regression fails against the old implementation. All 39 focused tests pass after the fix, all affected branches are covered, and existing exception tests remain intact. - Spotless and Checkstyle checks targeting exactly the two files both exit 0; four pre-existing warnings remain. Existing and tool-scope findings from the raw quality scans were reviewed; no violations were found in the task-owned changes. - The state check and fallback are supported by the federation path that closes Statements early and by the explicit requirements. No state fields, locks, or public contracts were added. Each non-cached Statement receives one additional state check; cleanup complexity remains O(n). ### Coverage Standalone local candidate: original task baseline `bdca16f1bcc`, current HEAD `e8759dc3cc6`. Only the uncommitted changes to the production class and its corresponding test were reviewed; unrelated changes were excluded. Existing JDBC cleanup contracts were preserved. Root-cause, impact, and test reviews, followed by a final convergence check, were completed for Statement cleanup and its regressions. Inventory and ledger validation passed, with no unresolved blocking evidence. This verdict covers code only; CI was not reviewed, and no live database failure reproduction is claimed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
