makssent opened a new pull request, #40102:
URL: https://github.com/apache/shardingsphere/pull/40102
Changes proposed in this pull request:
- `FirebirdGetBlobSegmentCommandExecutor` chooses the state of the
response with the last BLOB data by the new method `getLastSegmentState`, from
the client buffer size `p_sgmt_length`.
- When the client buffer has more than 2 bytes left after the last data,
the client receives state 2 (`SEGMENT_STATE_EOF`) together with the data, as
Firebird does, without an extra empty response; otherwise state 0.
- State 1 for a partly read segment and the response without data after
the end of BLOB do not change.
Verification:
The same protocol packets were executed directly against a real database and
through the proxy, and the results were compared.
* Server: Firebird 5.0
* Clients: Jaybird 6.0.6
BLOB of one segment "segment state" (`op_create_blob2`,
`op_batch_segments`, `op_close_blob`), opened with `op_open_blob2` and read by
three `op_get_segment`.
Before the fix:
| Packet | Proxy | Server | Match |
|---|---|---|---|
| `op_get_segment`: buffer of 4 bytes | object 1 (segment not complete),
data "se", success | object 1 (segment not complete), data "se", success | yes |
| `op_get_segment`: buffer of 64 bytes | object 0 (segment complete), data
"gment state", success | object 2 (end of BLOB), data "gment state", success |
no |
| `op_get_segment`: buffer of 64 bytes | object 2 (end of BLOB), no data,
success | object 2 (end of BLOB), no data, success | yes |
After the fix:
| Packet | Proxy | Server | Match |
|---|---|---|---|
| `op_get_segment`: buffer of 4 bytes | object 1 (segment not complete),
data "se", success | object 1 (segment not complete), data "se", success | yes |
| `op_get_segment`: buffer of 64 bytes | object 2 (end of BLOB), data
"gment state", success | object 2 (end of BLOB), data "gment state", success |
yes |
| `op_get_segment`: buffer of 64 bytes | object 2 (end of BLOB), no data,
success | object 2 (end of BLOB), no data, success | yes |
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
- [ ] I have specified the tool and the affected files or area for
substantial AI assistance, as required by the [AI-assisted contribution policy].
[AI-assisted contribution policy]:
https://github.com/apache/shardingsphere/blob/master/AI_POLICY.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
