terrymanu commented on PR #40091: URL: https://github.com/apache/shardingsphere/pull/40091#issuecomment-6033451726
### Result **Review Result: Mergeable** The cleanup stays within the authorized scope. No new blocking issues were found; this conclusion covers local configuration correctness only. ### Evidence - Maven Wrapper pins Maven 3.9.14. All 51 Maven invocations across the 15 target workflows use `./mvnw`. No explicit Wagon selection or relevant consumers were found. Dependency downloads use the default native HTTP transport; Wrapper bootstrap downloads use wget, curl, or JDK URL APIs. [Official reference](https://maven.apache.org/guides/mini/guide-resolver-transport.html) - Independent byte-for-byte verification confirms that only one line per file changed: three options removed from each of 15 files, totaling 45 occurrences. `http.keepAlive=false`, all other options, and configuration structures remain intact. No defensive code was added. HEAD, the index, and unrelated baseline files remain unchanged. - YAML parsing before and after the change for all 17 workflows, Spotless checks covering exactly the 15 changed files, and `git diff --check` all exited 0. The residual scan found no target properties (expected rg exit 1). actionlint exited 1 both before and after, with the same four pre-existing diagnostics and no new findings. ShellCheck/Pyflakes were not run. Checkstyle does not apply to YAML; RAT was not required. ### Coverage Standalone local candidate. The original task baseline was retained, with a pre-write snapshot protecting intervening user changes. Only this task’s parameter removals were reviewed; all pre-existing and intervening user changes were excluded. All 15 files under `/Users/zhangliang/IdeaProjects/shardingsphere/.github/workflows` were covered: `ci.yml`, `ci-graalvm.yml`, `ci-mcp.yml`, `e2e-agent.yml`, `e2e-mcp.yml`, `e2e-operation.yml`, `e2e-sql.yml`, `nightly-build.yml`, `nightly-check.yml`, `nightly-ci.yml`, `nightly-e2e-operation.yml`, `nightly-e2e-sql.yml`, `nightly-sql-parser.yml`, `release-mcp.yml`, and `schedule-report.yml`. Review passes covering root cause, impact, tests, and runtime paths, an independent defensive-code audit, and final convergence are complete. Inventory/ledger validation passed. Remote CI and complete Windows/GraalVM/Docker download paths were not executed; runner-provided settings/lib/ext were not inspected. No claim is made that the historical network failures have disappeared. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
