HhH666-ux commented on PR #40094: URL: https://github.com/apache/shardingsphere/pull/40094#issuecomment-6040262598
Apologies — I searched for existing PRs referencing this issue before starting, but missed #40002, which was opened the same day the issue was filed and takes the same approach in `OrderByContextEngine`. Closing this in favor of #40002. The one piece #40002 does not cover is resolving the dialect default in `ShardingDQLResultMerger#setGroupByForDistinctRow`: the injected GROUP BY items for DISTINCT reach `GroupByRowComparator` through the memory-merge path, which reads the stored `NullsOrderType` the same way. My branch (fix-issue-40001-distinct-nulls) still carries that as a standalone commit — feel free to cherry-pick it, and I've left a note on #40002. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
