The GitHub Actions job "E2E - Agent" on 
shardingsphere.git/fix-39084-single-table-metadata-missing has failed.
Run started by GitHub user zhang-arvin (triggered by linghengqian).

Head commit for run:
729492248abe409d0e29148f56ee6b18067d19ed / zhang-arvin <[email protected]>
Fix #39084: preserve schema and physical-table identity in missing-table check

Address review feedback on #39540.

The missing-table check flattened expected and loaded tables into global
sets keyed only by storage unit and a case-folded name, which lost two
things a table's identity needs:

- Schema. `public.foo` missing was masked by a loaded `archive.foo`.
- Physical-name case. Distinct physical tables `Foo` and `foo` collapsed
  into one, so a missing quoted table was never reported.

Expected and loaded tables are now compared as the full identity
`storageUnit.schema.physicalTable`, with the expected schema taken from
the material's default schema and the physical name kept case-sensitive
(no identifier-case folding on either side). The whole comparison is a
single set difference over flat LinkedHashSets, replacing the per-storage
maps, nested loops and dead null/missing-key fallbacks.

Tests assert the exact missing-identity set instead of substrings, and
cover same-name-in-other-schema, cross-storage-unit, case-sensitive
physical names, the schema-aware match, and the dialect-fallback WARN
retaining the original exception.

Report URL: https://github.com/apache/shardingsphere/actions/runs/37723409312

With regards,
GitHub Actions via GitBox

Reply via email to