terrymanu commented on PR #40107: URL: https://github.com/apache/shardingsphere/pull/40107#issuecomment-6063947226
### Result **Review Result: Mergeable** The local candidate meets the minimal fix scope. No blocking issues were found. This conclusion covers code correctness only; it does not confirm that remote CI or image publication succeeds. ### Evidence - `.github/workflows/nightly-build.yml:88,93,94,117,150` changes only five Action references and their version comments. All three SHAs exactly match the [ASF approved list](https://github.com/apache/infrastructure-actions/blob/47d14303c9aa2da451229a5ba8d156129ec4b22c/approved_patterns.yml#L162), and the version comments match the official metadata. - Independent inspection of `action.yml` at each pinned SHA confirms compatibility with the existing login inputs and the QEMU and Buildx calls without explicit inputs. Other Actions in the workflow already require Node 24. The confirmed plan accounts for the change in Buildx’s BuildKit image pull behavior. - YAML value comparison and `git diff --check` both exited with code 0. Semantic changes are limited to the five intended references. The exact single-file `spotless:check` exited with code 0; its log confirms that one file was checked and reports `BUILD SUCCESS`. - An independent audit against the complete defensive-code rules found no added or strengthened validation, fallbacks, retries, concurrency controls, or lifecycle protections. No defensive-code changes are required. ### Coverage - Candidate type: standalone local candidate. Baseline: `122c74c474604c7f8c3ee157fc0525842a2cbb96`. The local delta contains only five uncommitted line replacements in this workflow. Final file SHA256: `c03ae8413bb668eb45fbc6c36f46fc0f440a793b367562b72252025cdcbc3546`. - The inventory confirms that the complete scope consists of one build configuration file. Review covered root cause and behavior, impact and contracts, verification and operations, and a final convergence check. No unresolved issues remain. - Existing nightly build and publication behavior is preserved. No new project capabilities or architectural commitments are introduced. Checkstyle does not govern this YAML file. No files were added, and no license headers or RAT/POM configuration were changed, so RAT verification is not required. - This is a Code Correctness Review. Remote CI was not queried; local formatting verification is assessed separately from remote execution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
