linghengqian opened a new pull request, #2552: URL: https://github.com/apache/shardingsphere-elasticjob/pull/2552
For #2549 . Changes proposed in this pull request: - Fix Nacos integration nativetest for GraalVM Native Image. - The failure of the nativetest CI to start previously was related to updates in https://github.com/apache/infrastructure-actions/blob/main/actions.yml . > - **Regenerate the GraalVM reachability metadata** — `reachability-metadata/.../generated-reachability-metadata/reachability-metadata.json`, +230 / −128 lines. It is a byproduct of the pipeline change above and its output is non-deterministic, so it should land together with that item. It also still lacks the four shaded Nacos gRPC SPI entries `com.alibaba.nacos.shaded.io.grpc.LoadBalancerProvider`, `ManagedChannelProvider`, `NameResolverProvider` and `ServerProvider`, because `extra-filter.json` excludes `com.**`; a conditional-mode agent cannot record accesses made by filtered classes, so those four would need an unconditional, resources-only `reachability-metadata.json` under `META-INF/native-image/com.alibaba.nacos/nacos-client/3.2.4/`. That is a separate item in its own right if native Nacos is wanted. > - **CI: bump `graalvm/setup-graalvm` from v1.5.6 to v1.6.6** — `.github/workflows/graalvm.yml`, one line. While that file is being touched it is worth revisiting the `paths` filter, which only covers `graalvm.yml`, `reachability-metadata/src/**`, `test/native/native-image-filter/**` and `test/native/src/**`, and therefore does not trigger on `kernel/**`, `registry-center/**`, `spring/**` or `pom.xml`, and the `github.repository == 'apache/shardingsphere-elasticjob'` gate, which silently disables the job on forks. > - **Tests: native image coverage for the memory and Nacos registry centers** — `test/native/.../memory/MemoryJavaTest`, `MemoryOperationJavaTest`, `.../staticd/SpringBootMemoryRegistryCenterTest` and `.../nacos/NacosJavaTest`. These assert native-image compatibility of the new registry centers, which is a different concern from the Spring Boot Starter and Spring Namespace wiring, so they could move over to the native-image work. If maintainers consider native coverage part of this feature, this item can stay in #2548. > - **Tests: drop the obsolete `JavaTest` TODO and widen the sharding readiness wait** — `test/native/.../operation/JavaTest.java`. The TODO documenting that `removeJobConfiguration()` always makes a listener throw is obsolete once the kernel and registry-center items land. Separately, the `Awaitility.until` predicate only waited for the sharding count to reach three, but a returned `ShardingInfo` can still have a null `serverIp`, so the wait now also requires every entry to be populated and reuses the fetched collection instead of calling `getShardingInfo()` a second time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
