terrymanu commented on PR #40110: URL: https://github.com/apache/shardingsphere/pull/40110#issuecomment-6075383240
### Result **Review Result: Mergeable** Both reflection gaps are fixed. The current candidate passed the complete Native regression run, with no code blockers found. ### Evidence - Registered the existing no-argument constructor of ShardingTableRuleConfigurationValidator and the SQLFederationRuleConfiguration.providerType field. The RuleConfigurationValidator condition is satisfied before BVal uses them, following the existing manual metadata maintenance approach. - JSON validity, duplicate-key checks, preservation of existing entries, and diff checks passed. The resource in the built JAR matches the source byte for byte. JVM tests: 24 total, 0 failures, 0 errors, 17 expected skips. - The complete GraalVM CE 25.0.2 Native run exited with code 0: 24 tests discovered, 1 existing skip, 23 started, 23 successful, 0 failures. The XML results exactly match the frozen set of 24 test UIDs, with no duplicates. All three previously failing Hive paths passed. ### Coverage - Standalone local candidate: original baseline 122c74c, current HEAD 98667709. The authoritative scope contains only the manually maintained classpath resource META-INF/native-image/org.apache.shardingsphere/infra-reachability-metadata/reachability-metadata.json, with 23 uncommitted added lines. This path is unchanged between the two baselines. - The intended behavior is to restore existing Bean Validation functionality in Native execution. No new project commitments, public contracts, or dependencies were introduced. - Reflection instantiation and field access were reviewed across root cause, impact, testing, and runtime evidence. Final review convergence completed. The independent defensive-code audit found 0 additions. No evidence gaps remain, and ledger validation passed. - Checkstyle and Spotless: N/A because JSON is outside their configured scope. RAT: N/A because only an existing JSON file changed, with no new files or license/check configuration changes. - The conclusion covers the code changes. Runtime evidence comes from the local macOS arm64 environment; CI was not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
