terrymanu commented on PR #40118:
URL: https://github.com/apache/shardingsphere/pull/40118#issuecomment-6084381326
### Result
**Review Result: Mergeable**
The uncommitted Plan 1 change restores coverage data generation and passes
the complete local workflow. No blocking issues were found within the selected
scope.
### Evidence
- The current diff contains only five `${argLine}`→`@{argLine}` replacements
in the root POM. The empty default, existing JVM flags, and 0.95 threshold are
preserved.
- The current POM is byte-for-byte identical to the tested candidate, with
SHA256 still `da99f911…`. The verification evidence remains valid; the previous
review verdict was not used as evidence.
- All three stages using the original local commands passed: 443 modules;
2,666 XML reports recording 28,513 tests, 149 skipped, and zero failures or
errors; 210 fresh execution-data files. The original aggregation script
generated fresh HTML/XML reports, with the CLASS count of 4,555 matching the
CLI output.
- Independent compatibility checks passed: 20 Surefire and 20 Failsafe tests
in actual JDK 8 forks; one Surefire and one Failsafe test for each
skipped-agent and direct-goal scenario; Snowflake retained the Asia/Shanghai
timezone. The coverage-check verification exercised the existing 0.95 threshold
only for the selected Preconditions class, not overall coverage.
- Spotless checked the single root POM without cache skipping and exited
successfully. Repository-wide RAT also passed. Checkstyle does not apply to the
root POM.
- Plan 1 explicitly does not preserve CLI `-DargLine` override semantics and
introduces no compatibility commitment for arbitrary custom-property
combinations.
### Coverage
Standalone, local-only Code Correctness review. Original task baseline:
`7c0c433`; current HEAD: `d34a528`. Only the five task-owned POM changes were
assessed; unrelated version updates were excluded.
Root-cause, impact, and test-runtime analysis, followed by the final
convergence review, found no additional issues. The inventory and verification
evidence remain valid for the unchanged candidate. The independent
defensive-code audit passed; no defensive constructs were added.
GitHub CI was neither rerun nor reviewed. There are no staged changes. This
review did not execute Maven, Git writes, or remote operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
