terrymanu commented on PR #40119: URL: https://github.com/apache/shardingsphere/pull/40119#issuecomment-6084537814
### Result **Review Result: Mergeable** The local candidate satisfies the authorized Summary/XML replacement requirements. No blocking issues were found. ### Evidence - `.github/workflows/nightly-sql-parser.yml:70-95` preserves reporting after test failures, cancellation/skip conditions, and the existing CSV artifact; adds a separate artifact containing the original XML reports. - Independent defensive-code review confirms that `require_tests` and `fail_on_parse_error` preserve the previous script’s failure behavior for missing reports and malformed XML. No unsupported defensive configuration was added. - [Action v6.6.0 source](https://github.com/mikepenz/action-junit-report/blob/v6.6.0/src/main.ts#L147-L219) confirms that disabling annotations bypasses the Checks API. Comments remain disabled by default, so `contents: read` is sufficient. - The published bundle passed six local checks across both databases under Node 24: valid reports retain SQL, error messages, and multiline stack traces; missing and malformed XML fail as expected; no network calls occurred. - Spotless checked exactly one workflow file and exited with code 0; actionlint v1.7.12 also exited with code 0. Checkstyle is not applicable because no Java files changed. - Upstream failure details have a 50,000-character limit. Complete matching XML reports are retained in a separate artifact. ### Coverage Standalone local candidate based on `d34a52816dbe696c76e290d6b793e674891aa56a`. Both changed files were fully reviewed: the workflow modification and deletion of `.github/scripts/generate-sql-parser-report.py`. The existing POM modification in the original checkout was untouched. The review covers the explicitly authorized CI reporting and artifact changes without adding production functionality. Root-cause, contract-impact, runtime/verification checks, and full-scope convergence are complete; inventory/ledger validation passed with no unresolved issues. This conclusion covers code correctness only; remote CI and actual GitHub artifact uploads were not tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
