terrymanu commented on PR #40114: URL: https://github.com/apache/shardingsphere/pull/40114#issuecomment-6079526440
### Result **Review Result: Mergeable** The single-line plugin upgrade is within the authorized scope. Existing configuration remains compatible, and no blocking issues were found. ### Evidence - `pom.xml:203`: Dependency-Check upgraded from `12.1.6` to `13.0.0`; the CVSS threshold, scope filters, and suppression configuration are preserved. - The resolved plugin descriptor confirms support for all existing parameters. Java 21 and Maven 3.9.14 meet the minimum requirements of JDK 11 and Maven 3.8.1. Suppression schema 1.3 remains supported. - `dependency-check:help` and the exact-file POM `spotless:check -Pcheck` both exited with code 0. Spotless checked one POM. `apache-rat:check -Pcheck -T1C` exited with code 0. - `-N dependency-check:aggregate` succeeded using an isolated cache copy and generated an HTML report. A read-only database probe confirmed schema version 5.6 and a REFERENCE.URL length limit of 8000. Disabling updates initially prevented migration; enabling normal updates resolved this. - No defensive logic, application runtime dependencies, or architectural changes were introduced. Applicable Maven POM rules were satisfied. ### Coverage Standalone local-only Code Correctness Review, based on the clean working tree at `de2e6e1f4bd2c17768bbbbe20c89bb7d42cb11c9`. The complete candidate contains one line replacement in `pom.xml`. The review covered root cause and behavior, impact and contracts, and verification and operation. Final review found no additional issues or unresolved blockers. Checkstyle is not applicable because no Java files or governed resources changed. This conclusion covers code correctness only; CI was not reviewed. The smoke test covered only the root project with an old cache, not a full scan against current vulnerability data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
