terrymanu commented on PR #40121: URL: https://github.com/apache/shardingsphere/pull/40121#issuecomment-6092581044
### Result **Review Result: Mergeable** The upgrade and MCP date validation fix match the agreed scope. No blocking issues were found. ### Evidence - pom.xml:97: Upgraded the Jackson BOM to 2.22.3. - MCPCallToolResultFactory.java:45: Validation and serialization now share the same ObjectMapper, fixing the rejection of JavaTime values without adding a conversion layer or defensive code. - MCPCallToolResultFactoryTest.java:148: Two tests use the actual QUERY descriptor and fixed expectations of −0.5 and +0.5, while preserving the original structuredContent. - All 140 distinct related tests passed. Spotless/Checkstyle for both Java files, Spotless for the root POM, and Apache RAT all exited with code 0. - Factory coverage remains unchanged: CLASS 1/1, LINE 47/49, BRANCH 10/12. The added date scenarios are covered. An independent defensive-code review found no issues. ### Coverage Standalone local candidate based on 30516de3e738b7152a371fab8e9ed03e79e1a7bb. The complete task-owned delta consists of pom.xml, MCPCallToolResultFactory.java, and MCPCallToolResultFactoryTest.java. The user confirmed the upgrade, correct negative timestamp behavior, and MCP date response fix. Root cause, impact, tests, runtime paths, and the final consolidated diff were reviewed for both the dependency upgrade and validation/serialization behavior. No unresolved issues remain. This conclusion covers code correctness. Local style verification is complete; CI was not reviewed, and a full OWASP scan and native-image build were not performed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
