terrymanu commented on PR #40132: URL: https://github.com/apache/shardingsphere/pull/40132#issuecomment-6094808223
### Result **Review Result: Mergeable** The local candidate passed review with no blocking issues. This conclusion covers only the scope of this change. ### Evidence - The PR template preserves the default entry, corrects the placeholder, and aligns the verification command with `CODE_OF_CONDUCT.md:17`. AI disclosure requirements remain intact. - The Bug Report form preserves all seven original report topics. The five required fields and two prerequisite checkboxes are supported by the user-approved upgrade and existing reporting instructions. No unsupported restrictions were found. - File locations, extensions, field types, multiple selection, and required-field settings comply with [GitHub template rules](https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/about-issue-and-pull-request-templates) and the [form schema](https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema). - YAML parsing, form semantic assertions, scope checks, and `git diff --check` passed with exit code 0. Review inventory and review ledger validation also passed. ### Coverage - Standalone local candidate, based on `2d0e414aee8f18fe8c530cdc01285a3f94122086`, containing only working-tree changes to these five paths: - `.github/PULL_REQUEST_TEMPLATE` → `.github/PULL_REQUEST_TEMPLATE.md` - `.github/ISSUE_TEMPLATE/bug-report.md` → `.github/ISSUE_TEMPLATE/bug-report.yml` - The exact path update at `.licenserc.yaml:26`. - Requirements come from the user-approved recommendations 1 and 2 and existing contribution and reporting rules. Review covered PR submission, Bug Report submission, and license exclusions. All required review passes completed with no unresolved evidence gaps. - Feature, Question, and Git templates remain unchanged. No production runtime or performance changes. - Checkstyle and Spotless: Not Applicable; the current POM configuration does not cover these files. Both new files match the existing `**/.github/**` exclusion at `src/resources/rat.txt:30`, so RAT execution was unnecessary. - CI was not reviewed, and the remote GitHub interface was not tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
