terrymanu commented on PR #40135: URL: https://github.com/apache/shardingsphere/pull/40135#issuecomment-6095549019
### Result **Review Result: Mergeable** No blocking issues found. The change directly fixes the loss of the configured ref with minimal scope. ### Evidence - The loader includes the configured ref in API requests while preserving the existing download and recursion behavior. No public APIs or source-selection policies are added. - All 5 new test scenarios and 89 existing tests passed. Spotless, Checkstyle, and Apache RAT also passed. - PostgreSQL configuration matches the original code and continues to use master. - The current files match the verified version. ### Coverage - Standalone local candidate; baseline: f9761cbc2cc5f78f2296d83d126372ea19ae91c6. - Scope is limited to the [loader](/Users/zhangliang/.codex/worktrees/postgresql-parser-ci/shardingsphere/test/it/parser/src/main/java/org/apache/shardingsphere/test/it/sql/parser/external/loader/strategy/type/GitHubTestParameterLoadStrategy.java:84) and [regression tests](/Users/zhangliang/.codex/worktrees/postgresql-parser-ci/shardingsphere/test/it/parser/src/test/java/org/apache/shardingsphere/test/it/sql/parser/external/loader/strategy/type/GitHubTestParameterLoadStrategyTest.java:48). - Reviewed source URL conversion, directory recursion, and MySQL, PostgreSQL, and Presto consumers. Root cause, impact, and test coverage were assessed with no unresolved evidence gaps. - This conclusion covers code only. CI was not reviewed, and the full external integration tests were not rerun. It does not establish that the original PostgreSQL parsing failures are resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
