terrymanu commented on PR #40146: URL: https://github.com/apache/shardingsphere/pull/40146#issuecomment-6098437390
### Result **Review Result: Mergeable** This configuration change fixes the missing build-manual route mapping. No blocking issues were found. The conclusion covers code correctness only. ### Evidence - `.github/workflows/resources/linkcheck/markdown-link-check.json:35` only adds the `build-manual` category, reusing the existing documentation URL replacement rule and preserving paths and fragments. - The checker’s execution path was verified: unmapped links use the file protocol, and file-access errors produce status 400. After the fix, the links resolve to the correct HTTPS pages without ignoring links or relaxing accepted status codes. - Verification with the pinned checker passed: the Chinese and English Native Proxy documents each checked 2 links, with exit code 0. Regression checks confirmed that both fragments are preserved, 33 existing mappings remain unchanged, and missing files (400) and missing pages (404) remain classified as dead. - Independent defensive-code audit: no defensive branches, defaults, exception handling, or retries were added or strengthened. Existing exclusions, accepted status codes, and retry settings remain unchanged. ### Coverage - Standalone local candidate; task baseline `b1e09e9444f95b39449bdf5a2569de460f185896`, reviewed HEAD `60b513f3f06c05b86351d074910a46f08b769924`. The task-owned delta is limited to line 35 of the JSON file, excluding unrelated user changes and the existing `__pycache__`. - `build_review_inventory.py --base-ref b1e09e9444f95b39449bdf5a2569de460f185896 --head-ref HEAD --format json` ran with the specified single-file list, exited with code 0, and accounted for the complete one-file scope. - The behavior cluster is build-manual link mapping. The change repairs an existing documentation route without introducing public interfaces or new project commitments. Root-cause, impact, testing/runtime, and final convergence reviews are complete, with no unresolved evidence gaps. - Spotless is not applicable: configuration starting at `pom.xml:1354` covers Java, POM, and specified YAML files. Checkstyle is not applicable: `src/resources/checkstyle.xml:22` does not include JSON. No files were added, and no license headers or RAT rules changed. - Final candidate SHA-256: `3202f6e5c565e9205f10c456d992f9054afddf23d707ef990a5ade031780369a`, matching the verified candidate. CI was not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
