terrymanu commented on PR #40148:
URL: https://github.com/apache/shardingsphere/pull/40148#issuecomment-6099406896
### Result
**Review Result: Mergeable**
Added `@HighFrequencyInvocation` to 13 methods across 8 files. The local
code review passed.
### Evidence
- Verified the CREATE, OPEN, INFO, and SEEK request paths and applied
annotations at the smallest appropriate method scope. The nested
`BlobReadCursor.seek` is annotated separately and covers its private helper.
- The delta contains only 13 annotations and 8 imports, totaling 21 added
lines. Removing these additions makes all 8 files byte-for-byte identical to
the original baseline.
- The annotation uses `RetentionPolicy.SOURCE`; runtime logic, signatures,
and performance costs remain unchanged. Annotation placement follows the coding
standards.
- Independent defensive-code audit found no added or strengthened guards,
validation, fallbacks, copies, wrappers, catches, retries, concurrency
protection, or lifecycle protection.
- Exact-file style verification:
`./mvnw -B -pl
database/protocol/dialect/firebird,proxy/frontend/dialect/firebird
-DspotlessFiles="$TASK_SPOTLESS_FILES"
-Dcheckstyle.includes="$TASK_CHECKSTYLE_FILES"
-Dcheckstyle.includeResources=false -Dcheckstyle.includeTestResources=false
spotless:check checkstyle:check -Pcheck -T1C`
— **exit 0**. Both filters were generated from the 8 files below. Spotless
and Checkstyle selected exactly 3 protocol files and 5 frontend files, with no
violations or cached files skipped.
- Compilation:
`./mvnw -B -pl
database/exception/dialect/firebird,database/protocol/dialect/firebird,proxy/frontend/dialect/firebird
-DskipTests -Dspotless.skip=true compile`
— **exit 0; all three modules succeeded**. The initial two-module
compilation failed because the installed exception dependency lacked the
baseline's `InvalidSegstrTypeException`. Including its source module in the
reactor resolved the failure.
- No behavioral tests or benchmarks were added or run because this change
only adds SOURCE-retained markers. Source hashes, HEAD, and the change scope
remained unchanged after compilation.
### Coverage
Standalone local candidate based on
`46ad251d27aed18dd30ca1818f3844f8f6d7ab82`. The review covers only the
working-tree changes below; there are no task commits or staged changes.
Unrelated pre-existing changes were excluded and preserved.
| File and method line numbers | Annotated methods |
|---|---|
|
`database/protocol/dialect/firebird/src/main/java/org/apache/shardingsphere/database/protocol/firebird/constant/buffer/type/FirebirdBlobParameterBufferType.java:69,82,92`
| valueOf, isTraditionalType, createBuffer |
|
`database/protocol/dialect/firebird/src/main/java/org/apache/shardingsphere/database/protocol/firebird/constant/buffer/FirebirdParameterBuffer.java:82`
| readSizedIntValue |
|
`database/protocol/dialect/firebird/src/main/java/org/apache/shardingsphere/database/protocol/firebird/packet/command/query/blob/FirebirdCreateBlobCommandPacket.java:63`
| isStreamBlob |
|
`proxy/frontend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/blob/cache/FirebirdBlobReadCache.java:114,127,145,179`
| getTotalSize, isStreamBlob, seek, BlobReadCursor.seek |
|
`proxy/frontend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/blob/cache/FirebirdBlobWriteCache.java:184`
| isStreamBlob |
|
`proxy/frontend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/blob/FirebirdOpenBlobCommandExecutor.java:87`
| isStreamBlob |
|
`proxy/frontend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/info/FirebirdBlobInfoExecutor.java:63`
| isStreamBlob |
|
`proxy/frontend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/blob/FirebirdSeekBlobCommandExecutor.java:55`
| execute |
The review follows the requested scope, the high-frequency annotation
requirements in `CODE_OF_CONDUCT.md`, and existing production call paths. No
new behavior commitments were introduced. Coverage includes BPB decoding, BLOB
type restoration, and cursor/INFO/SEEK operations. Root-cause, blast-radius,
and test/runtime reviews were completed, followed by a final pass with no new
findings. The complete file inventory and review ledger passed validation, with
no unresolved evidence gaps.
This conclusion covers local code only; CI was not inspected. Local style
checks and production compilation passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
