The GitHub Actions job "Nightly - Check" on shardingsphere.git/master has 
failed.
Run started by GitHub user terrymanu (triggered by terrymanu).

Head commit for run:
608a0cd14fe1a636580d64435b5157f50586a881 / Arvin 
<[email protected]>
Fix #39084: Detect and warn about missing tables during metadata loading 
(#39540)

* Fix #39084: Detect and warn about missing tables during metadata loading

- Upgrade dialect loader SQLException log level from DEBUG to WARN
- Add checkMissingTables() to compare expected tables against actually loaded 
metadata
- Log WARN when tables from the inventory are missing from the loaded schema 
metadata

This prevents silent metadata loss when transient read failures drop
tables during startup, which was causing SINGLE tables to be missing
after application restarts.

* Fix #39084: satisfy MatchXpath checkstyle rule for null ternary

Use null == value with the null-result branch first, as required by the
MatchXpath rule in checkstyle.xml.

* Fix #39084: preserve schema and physical-table identity in missing-table check

Address review feedback on #39540.

The missing-table check flattened expected and loaded tables into global
sets keyed only by storage unit and a case-folded name, which lost two
things a table's identity needs:

- Schema. `public.foo` missing was masked by a loaded `archive.foo`.
- Physical-name case. Distinct physical tables `Foo` and `foo` collapsed
  into one, so a missing quoted table was never reported.

Expected and loaded tables are now compared as the full identity
`storageUnit.schema.physicalTable`, with the expected schema taken from
the material's default schema and the physical name kept case-sensitive
(no identifier-case folding on either side). The whole comparison is a
single set difference over flat LinkedHashSets, replacing the per-storage
maps, nested loops and dead null/missing-key fallbacks.

Tests assert the exact missing-identity set instead of substrings, and
cover same-name-in-other-schema, cross-storage-unit, case-sensitive
physical names, the schema-aware match, and the dialect-fallback WARN
retaining the original exception.

Report URL: https://github.com/apache/shardingsphere/actions/runs/38070687875

With regards,
GitHub Actions via GitBox

Reply via email to