terrymanu commented on PR #40163: URL: https://github.com/apache/shardingsphere/pull/40163#issuecomment-6127225831
### Result **Review Result: Mergeable** The current local candidate meets the authorized migration requirements with no code-scope blockers. The coverage gate still reports failures accurately. ### Evidence - `.github/workflows/ci-mcp.yml:59–62` retains unit tests and HTTP integration tests, removing only coverage collection and checking. - `.github/workflows/nightly-check.yml:180–203` reuses the existing collection, 95% per-class instruction coverage check, and aggregation commands. A coverage failure still fails the job while allowing reports to be generated and uploaded. - `nightly-check.yml:206` preserves the repository restriction, cancellation handling, and existing report dependency chain: collection, aggregation, Codecov, or artifact upload failures still prevent SonarCloud from running. - Parsing both latest YAML files and validating the complete scope returned exit code 0. Execution conditions remain identical to those verified across 16 scenarios. All 2,378 MCP tests passed, including 10 HTTP integration tests, with zero failures, errors, or skipped tests. - The original coverage check returned exit code 1: 11 API classes have 0% coverage, and the registry command has 84%. The original CI parameters reproduced the same API failure. Since the POMs, production code, and tests remain unchanged, these are existing coverage issues. The threshold was not lowered, and modules skipped by the reactor are not claimed to have passed the check. ### Coverage - Candidate: standalone local candidate; task baseline `25bd0cb6e2a147636e5548b38f51ba5fb61ab73c`. Both working-tree changes were fully reviewed: `.github/workflows/ci-mcp.yml` and `.github/workflows/nightly-check.yml`. Pre-existing untracked cache directories were excluded. - Requirements and commitments: the user explicitly accepted moving the original gate from PR CI to nightly, while retaining tests and the existing report/SonarCloud success chain. No production behavior, public contracts, or support commitments were added. - Behavior clusters: MCP coverage responsibility migration; report upload and SonarCloud prerequisites. Root cause and behavior, impact and contracts, and tests and runtime were reviewed, including counter-evidence. Final convergence found no new independent issues. Ledger validation returned exit code 0, with no unresolved decisive evidence gaps. - Local formatting: `./mvnw -N spotless:check -Pcheck -DspotlessFiles=<exact path regexes for both workflows>` returned exit code 0. Both files are clean; the modified nightly file was checked directly, while CI reused its previous passing result based on an unchanged file hash. Checkstyle is Not Applicable: `src/resources/checkstyle.xml:22` does not cover YAML. New step names and ASF headers were checked manually. - This result evaluates local code scope only. GitHub CI was neither queried nor reviewed, and local condition validation is not presented as an actual GitHub Actions run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
