FlyingZC commented on PR #40192:
URL: https://github.com/apache/shardingsphere/pull/40192#issuecomment-6166785856
### Result
**Review Result: Mergeable**
The statement-boundary defect caused by keyword-like psql variable names
is fixed. No blocking issues or required changes remain in the reviewed code.
### Evidence
- All 7 new regression cases failed before the fix and passed afterward.
All 133 loader tests pass.
- Parser module regression: 10,939 tests, zero failures, zero errors, 4
skipped.
- Exact-file Spotless and Checkstyle checks pass for both changed Java
files.
- Recognized plain variables are now consumed as complete markers,
preventing names such as `case`, `end`, and `begin` from changing SQL block
state. Independent
following SQL is preserved.
- Existing protections for arrays, SQL/JSON, strings, comments, typed
variables, and original echo boundaries remain covered.
- Full-repository tests were not rerun for this follow-up; earlier results
were not presented as validation of the updated candidate.
### Coverage
Reviewed Apache ShardingSphere PR #40192, including all 27 cumulative
changed blocks in `PostgreSQLExternalTestParameterLoadTemplate.java` and its
corresponding
test class. The reviewed content matches commit `4e708019a36e`, based on
`66f47ff8b41b`.
Completed root-cause, impact, tests/runtime, and full-scope convergence
review. The previously reported P2 issue is resolved, with no remaining
evidence gaps.
Local verification used `dbplus-engine-mvnw -f test/it/parser/pom.xml
-Pcheck` with exact two-file filters for `spotless:check` and
`checkstyle:check`; exit code
was 0, and selection of both files was confirmed.
No public API, SPI, grammar, visitor, or other-dialect changes. External
PostgreSQL IT and SQL E2E were not run. This is a code-correctness assessment;
CI was not
reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
