terrymanu commented on PR #40167: URL: https://github.com/apache/shardingsphere/pull/40167#issuecomment-6173162198
### Result Review Result: Mergeable No necessary code changes were identified in the current test-only patch. This is a code correctness assessment; CI was not reviewed. ### Evidence - All 55 changed files and 175 changed blocks reviewed, including an independent complete assessment. Behavior, contracts and test/runtime checks converged with no unresolved finding. - Fresh Spotless and Checkstyle checks passed for every changed Java file; exact selection was verified, including valid cached Checkstyle results. - Retained local test evidence remains valid after checking current sources, configuration and installed MCP artifacts: 2,704 unit tests and 10 HTTP integration tests passed. The final 40 registry cases were separately rerun after the last assertion edit. The full suite was not rerun during this review. - The known local coverage shortfall remains: six classes below 95%. No coverage-gate pass is claimed. ### Coverage - Candidate: [PR #40167](https://github.com/apache/shardingsphere/pull/40167/files), head `de964bf8a0ba183c631f99eef6436d5ed5b5f47b`; target base `e4bbda1a9c05a469fee5b448a1e0630b91093d3e`; merge-base `579a4d66ef733731ebe14bee7b4fc3de0c4e1905`. No local-only changes. - Requirements: current CODE_OF_CONDUCT, implementation/testing/non-regression rules, applicable Java standards and repository Checkstyle/Spotless configuration. Accepted scope is testing existing MCP behavior; production code, POMs, workflows, APIs/SPIs and SQL grammar are unchanged. - Behavior clusters: transport; capabilities/metadata/errors; SQL authorization/JDBC/transactions; feature workflows; descriptors/constraints; database validation; URI/workflow utilities; registry commands. - Completed lenses: root cause/behavior, contracts/blast radius, tests/runtime/operations, followed by independent full-scope review and convergence. Decisive evidence gaps: 0. CI scope: not reviewed. Style scope is the exact 55-file inventory below, in its eight owning Maven modules. Both checks apply to every file. Sanitized commands: ```bash ./mvnw -pl <eight owning modules below> -DspotlessFiles='<anchored exact-path regexes for all 55 files>' -Dcheckstyle.includes='<all 55 source-root-relative paths>' -Dcheckstyle.includeResources=false -Dcheckstyle.includeTestResources=false spotless:check checkstyle:check -Pcheck -T1C -B -ntp # Exit 0; Spotless selected 55 files, with no changes needed. ./mvnw -pl <same eight modules> -Dcheckstyle.includes='<same 55 source-root-relative paths>' -Dcheckstyle.includeResources=false -Dcheckstyle.includeTestResources=false checkstyle:check -Pcheck -T1 -B -ntp -Dcheckstyle.cache.file='<review-owned cache path>' # Exit 0; selection proof accounts for all 55 files: # 10 in result XML and 45 valid cached files. # The cache override property did not change Maven's configured cache. ``` The following prefixes and filenames identify every covered PR-impact file: ```text mcp/bootstrap/src/test/java/org/apache/shardingsphere/mcp/bootstrap/ transport/HttpTransportOriginUtilsTest.java transport/MCPTransportErrorFactoryTest.java transport/capability/completion/MCPCompletionSpecificationFactoryTest.java transport/capability/resource/MCPResourceSpecificationFactoryTest.java transport/capability/tool/MCPToolSpecificationFactoryTest.java transport/server/http/SessionAttributionResolverTest.java transport/server/stdio/SessionManagedStdioTransportProviderTest.java mcp/core/src/test/java/org/apache/shardingsphere/mcp/ core/completion/MCPCompletionServiceTest.java core/handler/core/CoreHandlerProviderTest.java core/metadata/GovernanceMetadataQueryServiceTest.java core/protocol/error/MCPErrorConverterTest.java core/resource/MCPResourceControllerTest.java core/tool/handler/ToolDefinitionRegistryTest.java core/tool/handler/execute/ExecuteUpdateToolHandlerTest.java core/tool/handler/execute/MCPJdbcStatementExecutorTest.java core/tool/handler/execute/MCPJdbcTransactionResourceManagerTest.java core/tool/handler/execute/MCPJdbcTransactionStatementExecutorTest.java core/tool/handler/execute/MCPSQLExecutionFacadeTest.java mcp/features/encrypt/src/test/java/org/apache/shardingsphere/mcp/feature/encrypt/ tool/model/EncryptWorkflowRequestTest.java tool/service/EncryptWorkflowApplyArtifactValidatorTest.java tool/service/EncryptWorkflowValidationServiceTest.java mcp/features/readwrite-splitting/src/test/java/org/apache/shardingsphere/mcp/feature/readwritesplitting/ tool/model/ReadwriteSplittingRuleWorkflowRequestTest.java tool/model/ReadwriteSplittingStatusWorkflowRequestTest.java tool/service/ReadwriteSplittingAlgorithmRecommendationServiceTest.java tool/service/ReadwriteSplittingInspectionServiceTest.java tool/service/ReadwriteSplittingStatusWorkflowPlanningServiceTest.java mcp/features/shadow/src/test/java/org/apache/shardingsphere/mcp/feature/shadow/ tool/model/ShadowAlgorithmCleanupWorkflowRequestTest.java tool/model/ShadowDefaultAlgorithmWorkflowRequestTest.java tool/model/ShadowRuleWorkflowRequestTest.java tool/service/ShadowAlgorithmRecommendationServiceTest.java tool/service/ShadowInspectionServiceTest.java mcp/features/sharding/src/test/java/org/apache/shardingsphere/mcp/feature/ sharding/resource/handler/ShardingTableResourceHandlerTest.java sharding/tool/handler/PlanShardingTableRuleToolHandlerTest.java sharding/tool/service/ShardingAlgorithmRecommendationServiceTest.java sharding/tool/service/ShardingDistSQLPlanningServiceTest.java sharding/tool/service/ShardingWorkflowPlanningServiceTest.java mcp/registry/src/test/java/org/apache/shardingsphere/mcp/registry/ MCPRegistryMetadataCommandTest.java mcp/support/src/test/java/org/apache/shardingsphere/mcp/ support/database/metadata/jdbc/MCPJdbcDatabaseProfileLoaderTest.java support/database/tool/service/RuntimeDatabaseValidationServiceTest.java support/descriptor/MCPCompletionTargetDescriptorValidatorTest.java support/descriptor/MCPDescriptorCatalogIndexTest.java support/descriptor/MCPDescriptorCatalogLoaderTest.java support/descriptor/MCPPromptDescriptorValidatorTest.java support/descriptor/MCPResourceDescriptorValidatorTest.java support/descriptor/MCPResourceNavigationDescriptorValidatorTest.java support/descriptor/MCPToolDescriptorCatalogValidatorTest.java support/descriptor/MCPToolInputSchemaValidatorTest.java support/descriptor/MCPToolOutputSchemaValidatorTest.java support/descriptor/yaml/validator/ISOOffsetDateTimeValidatorTest.java support/descriptor/yaml/validator/MCPDescriptionValidatorTest.java support/descriptor/yaml/validator/MCPPromptGuidanceMetaValidatorTest.java support/resource/MCPUriPathSegmentUtilsTest.java support/resource/MCPUriTemplateTest.java support/workflow/service/WorkflowLifecycleUtilsTest.java support/workflow/service/WorkflowPlanPayloadBuilderTest.java ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
