terrymanu commented on PR #40073: URL: https://github.com/apache/shardingsphere/pull/40073#issuecomment-6209289192
### Result Review Result: Mergeable No blocking issues were found at the current head. Both test coding-standard findings from the previous review are fixed. This conclusion covers code correctness only; CI was not reviewed. ### Evidence - Recursive CTE seed columns now use the existing `SubqueryTableBindUtils.createSubqueryProjections` utility, fixing the treatment of `*` and `t.*` as single columns while preserving explicit column-list mapping. [Production change](https://github.com/apache/shardingsphere/blob/164d0698501cd14362278f86f12ef2e015151e0d/infra/binder/core/src/main/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/with/CommonTableExpressionSegmentBinder.java#L133-L138) - Aliased columns follow the existing CTE column-name inference contract. [MySQL 8.0 documentation](https://dev.mysql.com/doc/refman/8.0/en/with.html), [PostgreSQL 17 documentation](https://www.postgresql.org/docs/17/sql-select.html) - After compiling the exact-head snapshot, all 15 `SelectStatementBinderTest` tests passed, including the new regression case, with no failures, errors, or skipped tests. ### Coverage - Candidate: public PR #40073, with no local code delta. - Head: `164d0698501cd14362278f86f12ef2e015151e0d`. - Base / merge-base: `5756b72bfa9da47c24c4856915fd8159ce60a1be`. Both head and base were confirmed unchanged before completion. - All 3 files in GitHub’s authoritative changed-file list were reviewed: - `RELEASE-NOTES.md:52` - `infra/binder/core/src/main/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/with/CommonTableExpressionSegmentBinder.java:133` - `infra/binder/core/src/test/java/org/apache/shardingsphere/infra/binder/engine/statement/dml/SelectStatementBinderTest.java:498` - Requirements basis: Issue #35164, existing Binder contracts, CODE_OF_CONDUCT, and applicable implementation and testing rules. This restores existing behavior without adding a project commitment. - Reviewed projection expansion, aliases, explicit column lists, recursive-member and outer-query binding, SEARCH/CYCLE, tests, and release notes. Completed root-cause, blast-radius, and test/runtime review passes, followed by a final convergence pass. No unresolved evidence gaps remain. - Local style verification command: `./mvnw -pl infra/binder/core -DspotlessFiles="$JAVA_REGEX" -Dcheckstyle.includes="$JAVA_INCLUDES" -Dcheckstyle.includeResources=false -Dcheckstyle.includeTestResources=false spotless:check checkstyle:check -Pcheck -T1C` The combined command exited with code `0`. The variables restrict selection to the two Java files above using canonical absolute-path regular expressions and source-root-relative paths, respectively. Spotless confirmed exactly 2 files selected and clean; Checkstyle XML confirmed coverage of the same 2 files with no error-level violations. - Both checks are Not Applicable to `RELEASE-NOTES.md`: the current configuration does not cover Markdown. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
