strongduanmu commented on PR #40207:
URL: https://github.com/apache/shardingsphere/pull/40207#issuecomment-6211167217
• ### Result
Review Result: Mergeable
All three previous issues are fixed. No blocking issues or required
changes remain. This
assessment covers code correctness.
### Evidence
• Local %TYPE references: declaration order and lexical scope distinguish
variables from
physical tables, including nested scopes, quoted identifiers, block
labels, and subprogram
qualifiers. Real table references remain available.
• SELECT DBLink: complete dotted link names survive parsing, binding, and
SQL federation
conversion.
• Anonymous-block assertions: the schema-qualified fixture now uses the
matching expected
type and checks tables, columns, and empty collections. Removing actual
metadata correctly
fails the assertion.
• All 2,030 Oracle Parser IT tests, 19 Unsupported Parser IT tests, and
113 Binder IT tests
passed, with zero failures, errors, or skipped tests. All 23 added SQL
IDs entered the
test parameter collection, and all 14 changed XML files matched the
resources loaded
during execution.
### Coverage
• Latest public commit: 6016876a2afe11d9b94cbe6fa8d356a5f696d3c2.
• Original baseline/merge-base: fec1f87710d658e43eac95815e223a5108341dff.
• Complete scope: 28 files and 72 changed blocks; the PR contains +441/-23
lines. The 10 fix
files are committed. Other imported code and the agreed com/sphereex
exclusion remain
unchanged.
• The reviewed candidate consisted of public head 737ec9a plus the
authorized fixes. The
latest public commit was verified to contain identical reviewed content.
• The complete scope underwent root-cause and behavior analysis, impact
and contract
analysis, test and runtime analysis, and a final convergence pass.
Independent review
completed with no unresolved outcome-sensitive evidence gaps.
• Coverage includes Oracle grammar, anonymous-block models and declaration
scope, DBLink
handling, shared GROUP BY binding, JAXB assertions, SQL fixtures, and
the release note.
Oracle has no maintained branch dialect in this repository; shared
binding consumers in
other dialects were also inspected.
• Requirements were assessed against the current PR scope, repository
rules, and official
Oracle 19c semantics. The changes introduce no SPI, module dependency,
or cross-request
state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
