terrymanu commented on PR #40220: URL: https://github.com/apache/shardingsphere/pull/40220#issuecomment-6249912721
### Result Review Result: Mergeable The latest public commit, `4710947f69342b7f017aff7b42c2483ba14f66ee`, includes both fix files. The full code review passed. No blocking issues or recommended changes remain. This conclusion covers code correctness only. CI was not reviewed. ### Evidence - All 12 PR files match the verified content. There are no uncommitted local code changes. - Verified and reused the 379-test module results; the final 24-test focused rerun validates the test source after the last formatting adjustment. - The relevant inputs for the previous 7,442 parser/core regression tests remain unchanged, so that evidence remains applicable. - PostgreSQL parse → projection SQL → reparse verification passed, preserving embedded double quotes and logical identifier names. All six branches introduced by the changed decisions are covered. - Both independent full reviews passed. Every candidate issue was individually reassessed, no unresolved differences remain, and review-session validation passed. ### Coverage - Public PR #40220, reviewed from original baseline `ea8fa38112739b6654f82ed180d9be84eb9de8d2`: all 12 files and 71 changed blocks. - Applied AGENTS.md, CODE_OF_CONDUCT.md, and existing PostgreSQL grammar/parser/visitor contracts. Checked PostgreSQL 18, “Lexical Structure,” §4.1.1 and the project’s SQL parser documentation. - Covered lexing, PostgreSQL visitors, shared identifier constructors, projection consumers, and tests. - Completed root-cause, blast-radius, and tests/runtime review passes, followed by convergence with zero new issues. - Checked the independent openGauss implementation and existing MySQL, Oracle, and SQLServer paths and regression evidence. Style command summary: `./mvnw -B -pl parser/sql/engine/dialect/postgresql,parser/sql/statement/core,test/it/parser,infra/rewrite/core spotless:check checkstyle:check -Pcheck -T1C` The actual command used exact filters for the following nine Java files and disabled resource scanning. Checkstyle and Spotless both exited with code 0. Source, configuration, tools, and coverage were verified unchanged, allowing valid reuse. | Module | Files covered by both style checks | |---|---| | PG engine | PostgreSQLStatementVisitor.java, PostgreSQLDALStatementVisitor.java, PostgreSQLDCLStatementVisitor.java, PostgreSQLDDLStatementVisitor.java | | parser statement core | IdentifierValue.java, IdentifierValueTest.java | | parser IT | InternalPostgreSQLParserIT.java | | rewrite core | SubstitutableColumnNameToken.java, SubstitutableColumnNameTokenTest.java | - Style Not Applicable: Literals.g4 and the two parser IT select-expression.xml files containing SQL and expected results. These files are outside the configured checks and were reviewed manually. - RAT Not Applicable: No new files, license-header changes, or related configuration changes. - This review was read-only. No code changes, Git writes, or GitHub CI queries were performed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
