terrymanu commented on PR #40239: URL: https://github.com/apache/shardingsphere/pull/40239#issuecomment-6267182272
### Result Review Result: Mergeable No blocking issues were found in the current code scope of [PR #40239](https://github.com/apache/shardingsphere/pull/40239). ### Evidence - Expected null semantics are preserved for catalog/schema, generated-key column names, and the DistSQL statement database type. - Database removal during failure handling no longer causes a secondary NPE to mask the original error. SQLExceptions retain their identity; generic exception wrapping preserves the cause; dialect mapping still uses the database’s protocol when the database exists. - Existing verification results were validated for reuse: 286 tests, with zero failures, errors, or skipped tests. Current source, configuration, tools, inputs, and complete verification scope were confirmed unchanged. ### Coverage - Public PR head: `8c62da6a808477ec12fa268d72eeea0bb6bce25c`; merge-base: `639c9176be0243f2682ebd8502271b1736aba788`. No additional local changes. - Assessment follows the public PR requirements, maintained JDBC/metadata/exception contracts, and repository rules. No new API, SPI, or configuration commitments are introduced. - All 10 files and 78 changed blocks were reviewed through root-cause, contract-impact, and test/runtime analysis, covering database diagnostics, transactions, exception conversion, metadata, DistSQL, and generated keys. Two consecutive rounds of independent paired reviews and coordinator assessment reached the same conclusion. All candidate concerns were resolved, with no outstanding evidence gaps. - Checkstyle and Spotless both cover every file below and both exited with code 0. Existing execution results were reused after confirming current-input equivalence. Paths below are relative to `jdbc/src/<type>/java/org/apache/shardingsphere/driver/jdbc/`: | Type | File | |---|---| | main | `adapter/AbstractStatementAdapter.java` | | main | `core/connection/ShardingSphereConnection.java` | | main | `core/datasource/metadata/ShardingSphereDatabaseMetaData.java` | | main | `core/statement/DistSQLStatementExecutor.java` | | main | `core/statement/ShardingSphereStatement.java` | | test | `core/connection/ShardingSphereConnectionTest.java` | | test | `core/datasource/metadata/ShardingSphereDatabaseMetaDataTest.java` | | test | `core/statement/DistSQLStatementExecutorTest.java` | | test | `core/statement/ShardingSpherePreparedStatementTest.java` | | test | `core/statement/ShardingSphereStatementTest.java` | Style verification command (paths sanitized): `./mvnw -B -pl jdbc -DspotlessFiles='<exact path regexes for the 10 files above>' -Dcheckstyle.includes='<source-root-relative paths for the 10 files above>' -Dcheckstyle.includeResources=false -Dcheckstyle.includeTestResources=false spotless:check checkstyle:check -Pcheck -T1C`. This conclusion covers code readiness only; CI was neither queried nor assessed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
