makssent opened a new issue, #40279: URL: https://github.com/apache/shardingsphere/issues/40279
### Before reporting a bug - [x] I have searched open and closed [GitHub issues](https://github.com/apache/shardingsphere/issues). - [x] I have read the [ShardingSphere documentation](https://shardingsphere.apache.org/document/current/en/overview). ### ShardingSphere version master, commit [`01446d4fad4`](https://github.com/apache/shardingsphere/commit/01446d4fad48450e7fc3eb3b3631b25d6bf411df) ### ShardingSphere project ShardingSphere-Proxy ### Expected behavior The proxy should execute a query with a recursive common table expression ([`WITH RECURSIVE`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/dsql/parse.y#L5869-L5873)) and an [`UPDATE`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/dsql/parse.y#L6754-L6762) with [`OLD`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/dsql/StmtNodes.cpp#L10554) and [`NEW`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/dsql/StmtNodes.cpp#L10556) columns in [`RETURNING`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/dsql/parse.y#L6822-L6836) as the Firebird server does. ### Actual behavior The proxy answers both statements with an error. The same statements were executed directly on the Firebird server and through the proxy: | Statement | Firebird server | Proxy | | --- | --- | --- | | `WITH RECURSIVE R (N) AS (SELECT 1 FROM RDB$DATABASE UNION ALL SELECT N + 1 FROM R WHERE N < 3) SELECT N FROM R` | Success, column N of type INTEGER, rows with N = 1, 2, 3 | Error [`isc_random`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/include/firebird/impl/msg/jrd.h#L63) "Unknown exception." | | `UPDATE T_PLAIN SET NAME = 'x' WHERE ID = -1 RETURNING OLD.NAME, NEW.NAME` | Success, two columns NAME of type VARCHAR, no rows | Error [`isc_random`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/include/firebird/impl/msg/jrd.h#L63) "Unknown exception." | So through the proxy an application cannot run recursive queries and cannot read the old and new values of changed rows with [`RETURNING`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/dsql/parse.y#L6822-L6836), and the error does not tell it why. ### Reason analysis - When the proxy prepares a statement, [`FirebirdPrepareStatementCommandExecutor#processReturnValues`](https://github.com/apache/shardingsphere/blob/01446d4fad48450e7fc3eb3b3631b25d6bf411df/proxy/frontend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/statement/prepare/FirebirdPrepareStatementCommandExecutor.java#L238-L265) describes each column projection by the table of the column. It [looks the table up by name](https://github.com/apache/shardingsphere/blob/01446d4fad48450e7fc3eb3b3631b25d6bf411df/proxy/frontend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/statement/prepare/FirebirdPrepareStatementCommandExecutor.java#L247-L252) in the schema and then in `system_tables`, and [takes the column from this table](https://github.com/apache/shardingsphere/blob/01446d4fad48450e7fc3eb3b3631b25d6bf411df/proxy/frontend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/frontend/f irebird/command/query/statement/prepare/FirebirdPrepareStatementCommandExecutor.java#L253). - A column without a physical table, the column `N` of the CTE `R` or `OLD.NAME` and `NEW.NAME` in [`RETURNING`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/dsql/parse.y#L6822-L6836), is not in this metadata. Describing it fails with an exception that reaches the client as [`UnknownSQLException`](https://github.com/apache/shardingsphere/blob/01446d4fad48450e7fc3eb3b3631b25d6bf411df/infra/common/src/main/java/org/apache/shardingsphere/infra/exception/generic/UnknownSQLException.java#L30-L32) with the message "Unknown exception." - The open pull request #40191 moves [this lookup](https://github.com/apache/shardingsphere/blob/01446d4fad48450e7fc3eb3b3631b25d6bf411df/proxy/frontend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/statement/prepare/FirebirdPrepareStatementCommandExecutor.java#L247-L252) into a new method, but does not handle a column that is not in this metadata. ### Steps to reproduce #### Environment - Firebird server 5.0. - Client: Jaybird 6.0.7. #### Steps 1. Create the table on the Firebird server: ```sql CREATE TABLE T_PLAIN (ID INTEGER NOT NULL PRIMARY KEY, NAME VARCHAR(20)); ``` 2. Start ShardingSphere-Proxy with this configuration: ```yaml # global.yaml authority: users: - user: root@% password: root privilege: type: ALL_PERMITTED props: proxy-frontend-database-protocol-type: Firebird ``` ```yaml # database-firebird.yaml databaseName: firebird_db dataSources: ds_0: url: jdbc:firebirdsql://<host>/<database file> username: <user> password: <password> rules: - !SINGLE tables: - "*.*" ``` 3. Execute the statements from the table under "Actual behavior" through the proxy and directly on the Firebird server, and compare the results. "Example code" runs all of them. ### Example code The statements from the table on Jaybird 6.0.7. The comment above each call shows what it prints against the Firebird server and through the proxy. ```java import java.sql.Connection; import java.sql.DriverManager; import java.sql.ResultSet; import java.sql.ResultSetMetaData; import java.sql.SQLException; import java.sql.Statement; import java.sql.Types; import java.util.ArrayList; import java.util.List; public class DescribeWithoutTable { // The proxy; put the URL of the Firebird server here to compare static final String URL = "jdbc:firebirdsql://<proxy host>:<proxy port>/firebird_db?encoding=UTF8&wireCrypt=DISABLED"; static final String USER = "root"; static final String PASSWORD = "root"; public static void main(final String[] args) throws SQLException { try (Connection connection = DriverManager.getConnection(URL, USER, PASSWORD)) { // Firebird server: "WITH RECURSIVE R (N) AS (SELECT 1 FROM RDB$DATABASE UNION ALL SELECT N + 1 FROM R WHERE N < 3) SELECT N FROM R -> N INTEGER: 1; 2; 3"; // proxy: "WITH RECURSIVE R (N) AS (SELECT 1 FROM RDB$DATABASE UNION ALL SELECT N + 1 FROM R WHERE N < 3) SELECT N FROM R -> error: Unknown exception. ..." execute(connection, "WITH RECURSIVE R (N) AS (SELECT 1 FROM RDB$DATABASE UNION ALL SELECT N + 1 FROM R WHERE N < 3) SELECT N FROM R"); // Firebird server: "UPDATE T_PLAIN SET NAME = 'x' WHERE ID = -1 RETURNING OLD.NAME, NEW.NAME -> NAME VARCHAR(20), NAME VARCHAR(20): no rows"; // proxy: "UPDATE T_PLAIN SET NAME = 'x' WHERE ID = -1 RETURNING OLD.NAME, NEW.NAME -> error: Unknown exception. ..." execute(connection, "UPDATE T_PLAIN SET NAME = 'x' WHERE ID = -1 RETURNING OLD.NAME, NEW.NAME"); } } // Executes the statement and prints the described columns with the rows, the update count or the error static void execute(final Connection connection, final String sql) { try (Statement statement = connection.createStatement()) { if (!statement.execute(sql)) { System.out.println(sql + " -> update count " + statement.getUpdateCount()); return; } try (ResultSet resultSet = statement.getResultSet()) { ResultSetMetaData metaData = resultSet.getMetaData(); List<String> columns = new ArrayList<>(); for (int i = 1; i <= metaData.getColumnCount(); i++) { int type = metaData.getColumnType(i); boolean text = Types.CHAR == type || Types.VARCHAR == type; columns.add(metaData.getColumnLabel(i) + " " + metaData.getColumnTypeName(i) + (text ? "(" + metaData.getPrecision(i) + ")" : "")); } List<String> rows = new ArrayList<>(); while (resultSet.next()) { List<String> values = new ArrayList<>(); for (int i = 1; i <= metaData.getColumnCount(); i++) { values.add(String.valueOf(resultSet.getObject(i))); } rows.add(String.join(", ", values)); } System.out.println(sql + " -> " + String.join(", ", columns) + ": " + (rows.isEmpty() ? "no rows" : String.join("; ", rows))); } } catch (final SQLException ex) { System.out.println(sql + " -> error: " + ex.getMessage()); } } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
