terrymanu commented on PR #40233: URL: https://github.com/apache/shardingsphere/pull/40233#issuecomment-6265528708
### Result Review Result: Mergeable No code correctness or test validity issues requiring changes were found. This conclusion covers code only; CI was not reviewed. ### Evidence All five scenarios include outcome assertions, covering initial progress persistence, skipping completed inventory tasks, persistence behavior for completed and incomplete callbacks, empty tasks, and incremental startup. The tests exercise the real `start()` method and captured public callbacks. All required mock handles are closed correctly. No production interfaces or test infrastructure were added. The following verification commands were executed. Variables abbreviate repeated paths: ```sh M=kernel/data-pipeline/core C=org.apache.shardingsphere.data.pipeline.core.task.runner.TransmissionTasksRunnerTest T=org/apache/shardingsphere/data/pipeline/core/task/runner/TransmissionTasksRunnerTest.java F="$(python3 -c 'import pathlib,re,sys; print(re.escape(str(pathlib.Path(sys.argv[1]).resolve())))' "$M/src/test/java/$T")" ./mvnw -pl "$M" -DskipITs -Dspotless.skip=true "-Dtest=$C" -Dsurefire.failIfNoSpecifiedTests=false test ./mvnw -X -pl "$M" "-DspotlessFiles=$F" "-Dcheckstyle.includes=$T" -Dcheckstyle.includeResources=false -Dcheckstyle.includeTestResources=false spotless:check checkstyle:check -Pcheck -T1C ./mvnw apache-rat:check -Pcheck -T1C ``` All three commands exited with **0**: - Focused tests: **5/5 passed**, with zero failures, errors, or skipped tests. - Spotless and Checkstyle: both explicitly selected the added file and passed. - Apache RAT: the added file was recognized as Apache-licensed. ### Coverage - PR HEAD: `c73aa12672232dd4d49b1337e97b329362e88607`. - Merge-base: `5983662c26672736f633e0e999238617407d1fef`. - The complete diff contains only [TransmissionTasksRunnerTest.java](https://github.com/apache/shardingsphere/blob/c73aa12672232dd4d49b1337e97b329362e88607/kernel/data-pipeline/core/src/test/java/org/apache/shardingsphere/data/pipeline/core/task/runner/TransmissionTasksRunnerTest.java#L59), with 146 added lines. Oracle changes are no longer part of the PR diff. - Root cause, impact scope, tests, runtime behavior, and final convergence were reviewed against `CODE_OF_CONDUCT.md` and existing production contracts. No production behavior, API/SPI, or dependency was added. - Six independent complete assessments were conducted across three rounds. The final two rounds reached stable conclusions and dispositions. Evidence, counter-evidence, and final review records were validated; no unresolved evidence gaps remain. - Full-module and repository-wide tests were not run. This review changed neither code nor Git state. The working tree is clean, and temporary review materials were removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
