makssent opened a new issue, #40287: URL: https://github.com/apache/shardingsphere/issues/40287
### Before reporting a bug - [x] I have searched open and closed [GitHub issues](https://github.com/apache/shardingsphere/issues). - [x] I have read the [ShardingSphere documentation](https://shardingsphere.apache.org/document/current/en/overview). ### ShardingSphere version master, commit [`01446d4fad4`](https://github.com/apache/shardingsphere/commit/01446d4fad48450e7fc3eb3b3631b25d6bf411df) ### ShardingSphere project ShardingSphere-Proxy ### Expected behavior The proxy should execute [`COMMIT RETAIN`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/dsql/parse.y#L5335-L5338) and [`ROLLBACK RETAIN`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/dsql/parse.y#L5341-L5344) as the Firebird server does, that is commit or roll back the work of the transaction and keep the transaction and its cursors open. ### Actual behavior The proxy rejects both statements with a syntax error. The same statements were executed directly on the Firebird server and through the proxy, one after another in one transaction with auto-commit off: | Steps | Firebird server | Proxy | | --- | --- | --- | | With auto-commit off, `SELECT ID FROM T_PLAIN WHERE ID = 6601` | Success, no rows | Success, no rows | | `COMMIT RETAIN` | Success | Error [`isc_dsql_error`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/include/firebird/impl/msg/jrd.h#L250) "Dynamic SQL Error; You have an error in your SQL syntax: COMMIT RETAIN, null" | | `ROLLBACK RETAIN` | Success | Error [`isc_dsql_error`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/include/firebird/impl/msg/jrd.h#L250) "Dynamic SQL Error; You have an error in your SQL syntax: ROLLBACK RETAIN, null" | So through the proxy an application cannot commit or roll back its work while keeping the transaction open. ### Reason analysis - The rules [`commit`](https://github.com/apache/shardingsphere/blob/01446d4fad48450e7fc3eb3b3631b25d6bf411df/parser/sql/engine/dialect/firebird/src/main/antlr4/imports/firebird/TCLStatement.g4#L26-L28) and [`rollback`](https://github.com/apache/shardingsphere/blob/01446d4fad48450e7fc3eb3b3631b25d6bf411df/parser/sql/engine/dialect/firebird/src/main/antlr4/imports/firebird/TCLStatement.g4#L30-L32) of the Firebird grammar of ShardingSphere have no [`RETAIN`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/dsql/parse.y#L5352-L5355), so the proxy rejects these statements with a syntax error. The operations [`op_commit_retaining`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/remote/server/server.cpp#L3425-L3427) and [`op_rollback_retaining`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/remote/server/server.cpp#L3421-L3423) tracked in #39938 do not cover these statements, because the client sends them as SQL text and the proxy rejects them in the parser. - Grammar support alone is not enough. [`CommitStatement`](https://github.com/apache/shardingsphere/blob/01446d4fad48450e7fc3eb3b3631b25d6bf411df/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/statement/type/tcl/CommitStatement.java#L25-L30) has no retain flag, [`ProxyBackendTransactionManager#commit`](https://github.com/apache/shardingsphere/blob/01446d4fad48450e7fc3eb3b3631b25d6bf411df/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/connector/jdbc/transaction/ProxyBackendTransactionManager.java#L108-L120) ends the transaction, after which [`ProxyDatabaseConnectionManager#closeExecutionResources`](https://github.com/apache/shardingsphere/blob/01446d4fad48450e7fc3eb3b3631b25d6bf411df/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/connector/ProxyDatabaseConnectionManager.java#L326-L331) closes the open cursors, and JDBC has no commit with retaining. So the proxy core needs a way to commi t or roll back with retaining as well. ### Steps to reproduce #### Environment - Firebird server 5.0. - Client: Jaybird 6.0.7. #### Steps 1. Create the table on the Firebird server: ```sql CREATE TABLE T_PLAIN (ID INTEGER NOT NULL PRIMARY KEY, NAME VARCHAR(20)); ``` 2. Start ShardingSphere-Proxy with this configuration: ```yaml # global.yaml authority: users: - user: root@% password: root privilege: type: ALL_PERMITTED props: proxy-frontend-database-protocol-type: Firebird ``` ```yaml # database-firebird.yaml databaseName: firebird_db dataSources: ds_0: url: jdbc:firebirdsql://<host>/<database file>?encoding=UTF8 username: <user> password: <password> rules: - !SINGLE tables: - "*.*" ``` 3. Turn auto-commit off, execute the statements from the table under "Actual behavior" in one transaction through the proxy and directly on the Firebird server, and compare the results. "Example code" runs all of them. ### Example code The statements from the table on Jaybird 6.0.7. The comment above each call shows what it prints against the Firebird server and through the proxy. ```java import java.sql.Connection; import java.sql.DriverManager; import java.sql.ResultSet; import java.sql.ResultSetMetaData; import java.sql.SQLException; import java.sql.Statement; import java.sql.Types; import java.util.ArrayList; import java.util.List; public class RetainStatements { // The proxy; put the URL, user and password of the Firebird server here to compare static final String URL = "jdbc:firebirdsql://<proxy host>:<proxy port>/firebird_db?encoding=UTF8&wireCrypt=DISABLED"; static final String USER = "root"; static final String PASSWORD = "root"; public static void main(final String[] args) throws SQLException { try (Connection connection = DriverManager.getConnection(URL, USER, PASSWORD)) { connection.setAutoCommit(false); // A statement before COMMIT RETAIN, so that the transaction already uses a backend connection of the proxy // Firebird server: "SELECT ID FROM T_PLAIN WHERE ID = 6601 -> ID INTEGER: no rows"; // proxy: "SELECT ID FROM T_PLAIN WHERE ID = 6601 -> ID INTEGER: no rows" execute(connection, "SELECT ID FROM T_PLAIN WHERE ID = 6601"); // Firebird server: "COMMIT RETAIN -> update count -1"; // proxy: "COMMIT RETAIN -> error: Dynamic SQL Error; You have an error in your SQL syntax: COMMIT RETAIN, null [SQLState:42000, ISC error code:335544569]" execute(connection, "COMMIT RETAIN"); // Firebird server: "ROLLBACK RETAIN -> update count -1"; // proxy: "ROLLBACK RETAIN -> error: Dynamic SQL Error; You have an error in your SQL syntax: ROLLBACK RETAIN, null [SQLState:42000, ISC error code:335544569]" execute(connection, "ROLLBACK RETAIN"); connection.commit(); } } // Executes the statement and prints the described columns with the rows, the update count or the error static void execute(final Connection connection, final String sql) { try (Statement statement = connection.createStatement()) { if (!statement.execute(sql)) { System.out.println(sql + " -> update count " + statement.getUpdateCount()); return; } try (ResultSet resultSet = statement.getResultSet()) { ResultSetMetaData metaData = resultSet.getMetaData(); List<String> columns = new ArrayList<>(); for (int i = 1; i <= metaData.getColumnCount(); i++) { int type = metaData.getColumnType(i); boolean text = Types.CHAR == type || Types.VARCHAR == type; columns.add(metaData.getColumnLabel(i) + " " + metaData.getColumnTypeName(i) + (text ? "(" + metaData.getPrecision(i) + ")" : "")); } List<String> rows = new ArrayList<>(); while (resultSet.next()) { List<String> values = new ArrayList<>(); for (int i = 1; i <= metaData.getColumnCount(); i++) { values.add(String.valueOf(resultSet.getObject(i))); } rows.add(String.join(", ", values)); } System.out.println(sql + " -> " + String.join(", ", columns) + ": " + (rows.isEmpty() ? "no rows" : String.join("; ", rows))); } } catch (final SQLException ex) { System.out.println(sql + " -> error: " + ex.getMessage()); } } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
