terrymanu commented on PR #40313: URL: https://github.com/apache/shardingsphere/pull/40313#issuecomment-6314337902
### Result Review Result: Mergeable No blocking issues found. The four protocol artifacts and their references are renamed consistently. No scope expansion is needed. ### Evidence - [PR #40313](https://github.com/apache/shardingsphere/pull/40313/files) changes only 32 artifactId entries across 22 POMs. Dependency versions, scopes, Java implementations, and SPIs remain unchanged. - Existing verification was checked for equivalence with the current commit and reused: the 351-module build, all 2,615 tests, and RAT passed. - The actual Proxy distribution contains each of the four renamed protocol JARs exactly once. They match the current build artifacts, with no old-named JARs present. ### Coverage - Public head: `3c67794a172e55385c30a72d52fb256cc2c49d39`; all 22 files and 29 changed blocks reviewed. - The review follows the PR’s explicit coordinate migration scope without assuming a mandatory naming-prefix rule. No protocol, API, or SPI semantics are added. - Producers, BOM entries, compile/runtime/test consumers, packaging, and loading paths were checked. Root-cause, blast-radius, tests/runtime, and convergence checks are complete. Four independent assessments across two rounds and the substantive report reviews agree, with no unresolved issues. - Spotless 3.10.1: all 22 POMs below were actually selected and passed, exit 0. Sanitized command summary: `./mvnw -B -ntp -T2 -pl "$modules" -DspotlessFiles="$pom_filters" spotless:check -Pcheck` `modules` contains the owning modules of these files; `pom_filters` contains their exact path regexes from the original invocation. Both are comma-separated. - `bom/pom.xml` - `database/protocol/dialect/firebird/pom.xml` - `database/protocol/dialect/mysql/pom.xml` - `database/protocol/dialect/opengauss/pom.xml` - `database/protocol/dialect/postgresql/pom.xml` - `kernel/data-pipeline/dialect/mysql/pom.xml` - `proxy/backend/dialect/firebird/pom.xml` - `proxy/backend/dialect/mysql/pom.xml` - `proxy/backend/dialect/opengauss/pom.xml` - `proxy/backend/dialect/postgresql/pom.xml` - `proxy/dialect/firebird/pom.xml` - `proxy/dialect/mariadb/pom.xml` - `proxy/dialect/mysql/pom.xml` - `proxy/dialect/opengauss/pom.xml` - `proxy/dialect/postgresql/pom.xml` - `proxy/frontend/dialect/firebird/pom.xml` - `proxy/frontend/dialect/mysql/pom.xml` - `proxy/frontend/dialect/opengauss/pom.xml` - `proxy/frontend/dialect/postgresql/pom.xml` - `test/e2e/operation/pipeline/pom.xml` - `test/e2e/operation/transaction/pom.xml` - `test/it/spi/pom.xml` - Checkstyle: Not Applicable. Its configured inputs cover Java/properties files, excluding POMs. - This conclusion is limited to code correctness. CI was not reviewed; full external-database E2E tests and Native compilation were not run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
