terrymanu commented on PR #40325:
URL: https://github.com/apache/shardingsphere/pull/40325#issuecomment-6332470806
### Result
Review Result: Mergeable
No blocking issues found. This conclusion covers code correctness only.
### Evidence
- The new constructor directly reuses the existing literal-message logic and
preserves the formatting constructors. Existing callers require no changes.
Message, SQLState, error code, and cause behavior remain compatible for
supported inputs.
- `./mvnw -B -pl infra/exception -Dspotless.skip=true test`: exit 0; all 47
tests passed.
- The current source matches the inputs of the previous local CodeQL
comparison. Within the selected 194-module scope, `java/tainted-format-string`
results decreased from 1 to 0. GitHub alert closure was not verified.
### Coverage
- Public PR head: `f9fe9228c17662b129f3dbeeb6f497394486fe85`.
- Comparison baseline: merge-base
`399fb3ee0eeb990a7662e80867c4423652ccfad5`; no additional local changes.
- Reviewed message handling, constructor compatibility, and regression tests
against the PR title, maintained exception contracts, and `CODE_OF_CONDUCT.md`.
The change introduces no new externally visible behavior commitments.
- All 4 files and 7 changed blocks in GitHub’s authoritative file list were
reviewed:
-
`infra/exception/src/main/java/org/apache/shardingsphere/infra/exception/external/sql/type/kernel/KernelSQLException.java`
-
`infra/exception/src/main/java/org/apache/shardingsphere/infra/exception/external/sql/type/kernel/category/PipelineSQLException.java`
-
`infra/exception/src/test/java/org/apache/shardingsphere/infra/exception/external/sql/type/kernel/KernelSQLExceptionTest.java`
-
`infra/exception/src/test/java/org/apache/shardingsphere/infra/exception/external/sql/type/kernel/category/PipelineSQLExceptionTest.java`
- Style command summary: `./mvnw -B -pl infra/exception <exact filters for
the 4 files above> spotless:check checkstyle:check -Pcheck -T1C`, exit 0. Both
checks covered all 4 files. A diagnostic `-X checkstyle:check` run with the
same scope confirmed selection of 2 production files and 2 test files, exit 0.
- Completed the behavior/root-cause, contract-impact, and tests/runtime
review lenses, followed by a final full-scope review. Two independent
assessments completed in one confirmation stage. All concerns were
cross-checked; no unresolved disagreements or evidence gaps remain.
- CI was neither queried nor reviewed. No code was modified during this
review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
