terrymanu commented on PR #40344: URL: https://github.com/apache/shardingsphere/pull/40344#issuecomment-6340315272
### Result Review Result: Mergeable No blocking issues or recommended changes remain. The two test metric increases are accepted under explicit authorization for this task. ### Evidence All three NOT regression scenarios failed before the fix and passed afterward. All 212 targeted tests passed; Binder used the extractor built from current source. Spotless passed for both files, and Checkstyle reported zero error-level violations. The coupling increase from 26 to 27 and fan-out increase from 32 to 33 fall within the explicitly accepted exception. The scanner retains exit code 1 for its test-only scope diagnostic. This was checked against the original two-file authorization; no unexplained scope changes remain. ### Coverage Standalone local candidate, original baseline: 27591ff6ad62c3d6051735f8dd93be87081067a6. Full coverage of: - parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/extractor/SubqueryExtractor.java - parser/sql/statement/core/src/test/java/org/apache/shardingsphere/sql/parser/statement/core/extractor/SubqueryExtractorTest.java Reviewed NOT extraction, SELECT recursion boundaries, and direct consumers. No new public contract was introduced. Under the complete rule set and latest authorization, two independent assessments completed all three review perspectives, convergence, and one confirmation stage. Coordinator review and record validation passed, with no evidence gaps. This conclusion covers local code only; CI was not reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
