schizophrenicmaniac commented on PR #40324: URL: https://github.com/apache/shardingsphere/pull/40324#issuecomment-6338854417
@terrymanu Thanks, agreed. I removed the Hikari check from DataSourcePoolPropertiesCreator and added `dataSourceClassName` = `com.zaxxer.hikari.HikariDataSource` to the skipped properties in HikariDataSourcePoolMetaData, so DataSourcePoolCreator filters it before calling setters. The regression test is now in HikariDataSourcePoolCreatorTest (the created HikariDataSource has no dataSourceClassName), and HikariDataSourcePoolMetaDataTest checks the new skipped entry. The core module no longer differs from master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
