This is an automated email from the ASF dual-hosted git repository.
terrymanu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new c55e5535cd6 Refactor OracleMetaDataLoader (#40343)
c55e5535cd6 is described below
commit c55e5535cd6ed53b506849268e952ef0119aa44b
Author: Liang Zhang <[email protected]>
AuthorDate: Thu Oct 22 19:55:02 2026 +0800
Refactor OracleMetaDataLoader (#40343)
---
.../oracle/metadata/data/loader/OracleMetaDataLoader.java | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git
a/database/connector/dialect/oracle/src/main/java/org/apache/shardingsphere/database/connector/oracle/metadata/data/loader/OracleMetaDataLoader.java
b/database/connector/dialect/oracle/src/main/java/org/apache/shardingsphere/database/connector/oracle/metadata/data/loader/OracleMetaDataLoader.java
index 5d1e2c2f018..c20011d0bf5 100644
---
a/database/connector/dialect/oracle/src/main/java/org/apache/shardingsphere/database/connector/oracle/metadata/data/loader/OracleMetaDataLoader.java
+++
b/database/connector/dialect/oracle/src/main/java/org/apache/shardingsphere/database/connector/oracle/metadata/data/loader/OracleMetaDataLoader.java
@@ -118,7 +118,8 @@ public final class OracleMetaDataLoader implements
DialectMetaDataLoader {
private Collection<String> loadViewNames(final Connection connection,
final Collection<String> tables, final String schema) throws SQLException {
Collection<String> result = new LinkedList<>();
- try (PreparedStatement preparedStatement =
connection.prepareStatement(getViewMetaDataSQL(tables))) {
+ String viewMetaDataSQL = getViewMetaDataSQL(tables);
+ try (PreparedStatement preparedStatement =
connection.prepareStatement(viewMetaDataSQL)) {
preparedStatement.setString(1, schema);
try (ResultSet resultSet = preparedStatement.executeQuery()) {
while (resultSet.next()) {
@@ -135,7 +136,8 @@ public final class OracleMetaDataLoader implements
DialectMetaDataLoader {
private Map<String, Collection<ColumnMetaData>>
loadColumnMetaDataMap(final Connection connection, final Collection<String>
tables, final String schema) throws SQLException {
Map<String, Collection<ColumnMetaData>> result = new
HashMap<>(tables.size(), 1F);
- try (PreparedStatement preparedStatement =
connection.prepareStatement(getTableMetaDataSQL(tables,
connection.getMetaData()))) {
+ String tableMetaDataSQL = getTableMetaDataSQL(tables,
connection.getMetaData());
+ try (PreparedStatement preparedStatement =
connection.prepareStatement(tableMetaDataSQL)) {
Map<String, Collection<String>> tablePrimaryKeys =
loadTablePrimaryKeys(connection, tables);
preparedStatement.setString(1, schema);
try (ResultSet resultSet = preparedStatement.executeQuery()) {
@@ -212,7 +214,8 @@ public final class OracleMetaDataLoader implements
DialectMetaDataLoader {
private Map<String, Collection<IndexMetaData>> loadIndexMetaData(final
Connection connection, final Collection<String> tableNames, final String
schema) throws SQLException {
Map<String, Collection<IndexMetaData>> result = new
HashMap<>(tableNames.size(), 1F);
- try (PreparedStatement preparedStatement =
connection.prepareStatement(getIndexMetaDataSQL(tableNames))) {
+ String indexMetaDataSQL = getIndexMetaDataSQL(tableNames);
+ try (PreparedStatement preparedStatement =
connection.prepareStatement(indexMetaDataSQL)) {
preparedStatement.setString(1, schema);
try (ResultSet resultSet = preparedStatement.executeQuery()) {
while (resultSet.next()) {
