terrymanu commented on a change in pull request #1106: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1106#discussion_r456362741
########## File path: elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/setup/JobClassNameIdentificationStrategy.java ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.elasticjob.lite.internal.setup; + +import org.apache.shardingsphere.elasticjob.api.ElasticJob; + +/** + * Identify job with job class name. + */ +public class JobClassNameIdentificationStrategy implements JobIdentificationStrategy { Review comment: need to final class here ########## File path: elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/setup/JobIdentificationStrategyFactory.java ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.elasticjob.lite.internal.setup; + +import lombok.AccessLevel; +import lombok.NoArgsConstructor; + +import java.util.ServiceLoader; + +/** + * Job identification strategy factory. + */ +@NoArgsConstructor(access = AccessLevel.PRIVATE) +public class JobIdentificationStrategyFactory { + + private static final JobIdentificationStrategy DEFAULT_STRATEGY = new JobClassNameIdentificationStrategy(); + + /** + * Get job identification strategy. + * + * @return job identification strategy + */ + public static JobIdentificationStrategy getStrategy() { Review comment: Should use static block to load SPI to avoid performance issue ########## File path: elasticjob-lite/elasticjob-lite-spring/src/main/java/org/apache/shardingsphere/elasticjob/lite/spring/setup/JobClassNameBySpringIdentificationStrategy.java ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.elasticjob.lite.spring.setup; + +import org.apache.shardingsphere.elasticjob.api.ElasticJob; +import org.apache.shardingsphere.elasticjob.lite.internal.setup.JobIdentificationStrategy; +import org.apache.shardingsphere.elasticjob.lite.spring.job.util.AopTargetUtils; +import org.springframework.aop.support.AopUtils; + +/** + * Identify job with job class name. + * <p> + * Consider the proxy object that generated by cglib or jdk dynamic proxy. + * </p> + */ +public class JobClassNameBySpringIdentificationStrategy implements JobIdentificationStrategy { + + @Override + public String identify(final ElasticJob elasticJob, final String jobName) { Review comment: Should return Optional for next JobIdentificationStrategy, just like response chain ########## File path: elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/setup/JobIdentificationStrategyFactory.java ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.elasticjob.lite.internal.setup; + +import lombok.AccessLevel; +import lombok.NoArgsConstructor; + +import java.util.ServiceLoader; + +/** + * Job identification strategy factory. + */ +@NoArgsConstructor(access = AccessLevel.PRIVATE) +public class JobIdentificationStrategyFactory { Review comment: need to final class here ########## File path: elasticjob-lite/elasticjob-lite-spring/src/main/resources/META-INF/services/org.apache.shardingsphere.elasticjob.lite.internal.setup.JobIdentificationStrategy ########## @@ -0,0 +1,18 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +org.apache.shardingsphere.elasticjob.lite.spring.setup.JobClassNameBySpringIdentificationStrategy Review comment: Need blank line for EOF ########## File path: elasticjob-lite/elasticjob-lite-spring/src/test/java/org/apache/shardingsphere/elasticjob/lite/spring/setup/JobIdentificationStrategyFactoryTest.java ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.elasticjob.lite.spring.setup; + +import org.apache.shardingsphere.elasticjob.lite.internal.setup.JobIdentificationStrategyFactory; +import org.junit.Test; + +import static org.hamcrest.CoreMatchers.instanceOf; +import static org.junit.Assert.assertThat; + +public class JobIdentificationStrategyFactoryTest { Review comment: Please add final for class ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
